Skip to content

Fix frontend health check timing issue in smoke tests #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyeder merged 1 commit into from
Dec 9, 2025
Merged

Fix frontend health check timing issue in smoke tests #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test-local-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,19 @@ jobs:
echo "⚠️ Backend deployment timeout - showing status"
kubectl get pods -n ambient-code -o wide
kubectl describe deployment backend-api -n ambient-code | tail -50
exit 1
}
kubectl wait --for=condition=available --timeout=180s deployment/frontend -n ambient-code || {
echo "⚠️ Frontend deployment timeout - showing status"
kubectl get pods -n ambient-code -o wide
kubectl describe deployment frontend -n ambient-code | tail -50
exit 1
}
kubectl wait --for=condition=available --timeout=180s deployment/agentic-operator -n ambient-code || {
echo "⚠️ Operator deployment timeout - showing status"
kubectl get pods -n ambient-code -o wide
kubectl describe deployment agentic-operator -n ambient-code | tail -50
exit 1
}

- name: Run Makefile smoke tests
Expand Down
24 changes: 20 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,28 @@ local-test-quick: check-kubectl check-minikube ## Quick smoke test of local envi
@minikube status >/dev/null 2>&1 && echo "$(COLOR_GREEN)✓$(COLOR_RESET) Minikube running" || (echo "$(COLOR_RED)✗$(COLOR_RESET) Minikube not running" && exit 1)
@echo "$(COLOR_BLUE)▶$(COLOR_RESET) Testing namespace..."
@kubectl get namespace $(NAMESPACE) >/dev/null 2>&1 && echo "$(COLOR_GREEN)✓$(COLOR_RESET) Namespace exists" || (echo "$(COLOR_RED)✗$(COLOR_RESET) Namespace missing" && exit 1)
@echo "$(COLOR_BLUE)▶$(COLOR_RESET) Testing pods..."
@kubectl get pods -n $(NAMESPACE) 2>/dev/null | grep -q "Running" && echo "$(COLOR_GREEN)✓$(COLOR_RESET) Pods running" || (echo "$(COLOR_RED)✗$(COLOR_RESET) No pods running" && exit 1)
@echo "$(COLOR_BLUE)▶$(COLOR_RESET) Waiting for pods to be ready..."
@kubectl wait --for=condition=ready pod -l app=backend -n $(NAMESPACE) --timeout=60s >/dev/null 2>&1 && \
kubectl wait --for=condition=ready pod -l app=frontend -n $(NAMESPACE) --timeout=60s >/dev/null 2>&1 && \
echo "$(COLOR_GREEN)✓$(COLOR_RESET) Pods ready" || (echo "$(COLOR_RED)✗$(COLOR_RESET) Pods not ready" && exit 1)
@echo "$(COLOR_BLUE)▶$(COLOR_RESET) Testing backend health..."
@curl -sf http://$$(minikube ip):30080/health >/dev/null 2>&1 && echo "$(COLOR_GREEN)✓$(COLOR_RESET) Backend healthy" || (echo "$(COLOR_RED)✗$(COLOR_RESET) Backend not responding" && exit 1)
@for i in 1 2 3 4 5; do \
curl -sf http://$$(minikube ip):30080/health >/dev/null 2>&1 && { echo "$(COLOR_GREEN)✓$(COLOR_RESET) Backend healthy"; break; } || { \
if [ $$i -eq 5 ]; then \
echo "$(COLOR_RED)✗$(COLOR_RESET) Backend not responding after 5 attempts"; exit 1; \
fi; \
sleep 2; \
}; \
done
@echo "$(COLOR_BLUE)▶$(COLOR_RESET) Testing frontend..."
@curl -sf http://$$(minikube ip):30030 >/dev/null 2>&1 && echo "$(COLOR_GREEN)✓$(COLOR_RESET) Frontend accessible" || (echo "$(COLOR_RED)✗$(COLOR_RESET) Frontend not responding" && exit 1)
@for i in 1 2 3 4 5; do \
curl -sf http://$$(minikube ip):30030 >/dev/null 2>&1 && { echo "$(COLOR_GREEN)✓$(COLOR_RESET) Frontend accessible"; break; } || { \
if [ $$i -eq 5 ]; then \
echo "$(COLOR_RED)✗$(COLOR_RESET) Frontend not responding after 5 attempts"; exit 1; \
fi; \
sleep 2; \
}; \
done
@echo ""
@echo "$(COLOR_GREEN)✓ Quick smoke test passed!$(COLOR_RESET)"

Expand Down
Loading