RHOAIENG-51481: switch pull_request_target to pull_request#763
Merged
Gkrumbach07 merged 1 commit intomainfrom Mar 2, 2026
Merged
RHOAIENG-51481: switch pull_request_target to pull_request#763Gkrumbach07 merged 1 commit intomainfrom
Gkrumbach07 merged 1 commit intomainfrom
Conversation
Contributor
Author
|
Long-term, we want a "safe-to-test" label that operates on the exact sha that is safe to test, rather than blindly trust-on-first-use |
ktdreyer
changed the title
ktdreyer
commented
Mar 2, 2026
ktdreyer
force-pushed
the
kdreyer/disable-pull-request-target
branch
from
4886f15 to
7b32be4
Compare
Contributor
Author
|
Upon reflection, these workflows will likely run-and-fail now, because we're not adding guards "don't run these PRs from forks at all". I will add conditionals so we only execute these EDIT: I've done this now. |
External contributors disclosed vulnerabilities in our pull_request_target workflows. Switching to pull_request prevents untrusted fork code from running with access to repository secrets. Leave the dependabot-auto-merge workflow unchanged, because it checks github.actor as a guard and never checks out code. Now that we are running these workflows on pull_request triggers, forks will not have access to the GHA secrets. Skip running these workflows altogether on PRs that originate from forks, rather than failing when GHA cannot find the secrets any more. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ktdreyer
force-pushed
the
kdreyer/disable-pull-request-target
branch
from
7b32be4 to
ca12dcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External contributors disclosed vulnerabilities in our
pull_request_targetworkflows. Switching topull_requestprevents untrusted fork code from running with access to repository secrets.Leave the dependabot-auto-merge workflow unchanged, because it checks
github.actoras a guard and never checks out code.Once we merge this, these workflows will no longer act on forks.
Fixes: #749
https://issues.redhat.com/browse/RHOAIENG-51481