Skip to content

feat(frontend): replace custom components with shadcn/ui equivalents#816

Closed
jeremyeder wants to merge 1 commit intoambient-code:mainfrom
jeremyeder:jeder/shadcn-ui-clean
Closed

feat(frontend): replace custom components with shadcn/ui equivalents#816
jeremyeder wants to merge 1 commit intoambient-code:mainfrom
jeremyeder:jeder/shadcn-ui-clean

Conversation

@jeremyeder
Copy link
Contributor

Jira: RHOAIENG-51883

Summary

  • Replaced 4 custom component implementations with standard shadcn/ui equivalents (Breadcrumb, Popover, Sonner toast, DataTable with TanStack Table)
  • Added 6 new shadcn components: Command palette (Cmd+K), Sheet (mobile nav), Sidebar (workspace layout), Collapsible, HoverCard, Pagination
  • Deleted 5 files of hand-rolled code (~1,574 lines removed): breadcrumbs.tsx, simple-data-table.tsx, toast.tsx, toaster.tsx, use-toast.tsx
  • Net change: +3,945 lines across 63 files

Test plan

  • Verify workspace pages render with Sidebar layout and Breadcrumb navigation
  • Test mobile navigation Sheet drawer on narrow viewport
  • Confirm Command palette opens with Cmd+K and searches projects
  • Verify toast notifications work via Sonner across all forms (connection cards, session actions, settings)
  • Test HoverCard previews on session name links in sessions table
  • Confirm Collapsible sections toggle in settings and create-session dialog
  • Test Pagination controls on workspaces and sessions tables
  • Verify no regressions in session detail page

🤖 Generated with Claude Code


Supersedes #778 - this is a clean rebase with single commit history

Audit and migrate frontend to use standard shadcn/ui components,
replacing hand-rolled implementations with maintained Radix-based
primitives. Removes ~1,574 lines of custom code.

Replaced:
- Custom Breadcrumbs → shadcn Breadcrumb
- Hand-rolled Popover (202 lines with portal/positioning) → Radix Popover (48 lines)
- Radix Toast/Toaster/useToast → Sonner (simpler API, toast() function)
- SimpleDataTable → TanStack Table DataTable with sorting/filtering/column visibility

Added:
- Command palette (Cmd+K) with project search and navigation
- Sheet drawer for mobile navigation
- Sidebar layout for workspace pages
- Collapsible sections in settings and session creation
- HoverCard previews on session names
- Standardized Pagination component with page number display

Deleted:
- breadcrumbs.tsx, simple-data-table.tsx, toast.tsx, toaster.tsx, use-toast.tsx

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@jeremyeder jeremyeder force-pushed the jeder/shadcn-ui-clean branch from 2703d8b to 04038b5 Compare March 5, 2026 03:27
@jeremyeder jeremyeder closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant