Skip to content

mergify: add coderabbit, remove amber-review#881

Merged
ktdreyer merged 1 commit intomainfrom
kdreyer/mergify-rm-amber-review
Mar 11, 2026
Merged

mergify: add coderabbit, remove amber-review#881
ktdreyer merged 1 commit intomainfrom
kdreyer/mergify-rm-amber-review

Conversation

@ktdreyer
Copy link
Copy Markdown
Contributor

We're using CodeRabbit on PRs instead.

We're using CodeRabbit on PRs instead.
@ktdreyer ktdreyer requested a review from mprpic March 10, 2026 22:02
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 10, 2026

Walkthrough

Modified the default queue rule condition in .mergify.yml from check-success=amber-review to commented-reviews-by=coderabbitai[bot], changing the merge queue trigger from checking a status check to checking for bot comments.

Changes

Cohort / File(s) Summary
Mergify Configuration
.mergify.yml
Updated queue rule condition to trigger based on bot comments instead of status check.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • mprpic
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: replacing the amber-review queue rule condition with a CodeRabbit bot comment condition in mergify.yml.
Description check ✅ Passed The description is related to the changeset, providing context for why the change was made (switching from amber-review to CodeRabbit).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kdreyer/mergify-rm-amber-review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 10, 2026

🧪 CI Insights

Here's what we observed from your CI run for 799e236.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.mergify.yml:
- Line 9: The current MerGify rule uses the PR-scoped condition
"commented-reviews-by=coderabbitai[bot]" which does not re-evaluate per head
SHA; replace it with a head-SHA-scoped status/check-run condition (e.g., revert
to "check-success=amber-review" or a new "check-success=code-rabbit-check"
check-run) so the gate is evaluated for each commit, or alternatively ensure
CodeRabbit is fully integrated by adding a GitHub Actions workflow in
.github/workflows that runs on push and produces the named check-run; update the
condition in .mergify.yml accordingly to reference that check-run name instead
of the commented-reviews-by predicate.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 09affe78-9501-4db8-b567-fd20d91fdb2d

📥 Commits

Reviewing files that changed from the base of the PR and between 0369c87 and 799e236.

📒 Files selected for processing (1)
  • .mergify.yml

@mprpic
Copy link
Copy Markdown
Contributor

mprpic commented Mar 11, 2026

This won't auto-merge either since it's still waiting for the amber review:
image

PRs after this one should 🤞

@ktdreyer ktdreyer merged commit 8d50ead into main Mar 11, 2026
8 checks passed
@ktdreyer ktdreyer deleted the kdreyer/mergify-rm-amber-review branch March 11, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants