fix: rm jira mcp card from screen#904
Conversation
WalkthroughMCP credential support has been removed from the integrations client component, including related types, constants, and UI rendering logic. The component now renders a simplified single grid layout containing only standard integration cards (GitHub, Google Drive, GitLab, Jira) while preserving existing loading state and connection card functionality. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/frontend/src/app/integrations/IntegrationsClient.tsx`:
- Around line 36-56: Remove the now-orphaned MCP-related code: delete the
MCPCredentialCard component, the useMcpCredentials hook, and the mcp-credentials
API module; ensure there are no remaining imports of MCPCredentialCard,
useMcpCredentials, or the mcp-credentials API across the codebase (remove from
any barrel exports), and run the build/type-check to confirm nothing else
references those symbols.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7d1185b9-1989-42b5-9e5a-490a70a2fd1d
📒 Files selected for processing (1)
components/frontend/src/app/integrations/IntegrationsClient.tsx
| <div className="grid grid-cols-1 md:grid-cols-2 gap-6"> | ||
| <GitHubConnectionCard | ||
| appSlug={appSlug} | ||
| showManageButton={true} | ||
| status={integrations?.github} | ||
| onRefresh={refetch} | ||
| /> | ||
| <GoogleDriveConnectionCard | ||
| showManageButton={true} | ||
| status={integrations?.google} | ||
| onRefresh={refetch} | ||
| /> | ||
| <GitLabConnectionCard | ||
| status={integrations?.gitlab} | ||
| onRefresh={refetch} | ||
| /> | ||
| <JiraConnectionCard | ||
| status={integrations?.jira} | ||
| onRefresh={refetch} | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify MCPCredentialCard and use-mcp-credentials are truly unused
echo "=== Searching for MCPCredentialCard imports ==="
rg -n "MCPCredentialCard" --type ts --type tsx -g '!*.test.*'
echo -e "\n=== Searching for use-mcp-credentials imports ==="
rg -n "use-mcp-credentials" --type ts --type tsx
echo -e "\n=== Searching for mcp-credentials API imports ==="
rg -n "from.*mcp-credentials" --type ts --type tsxRepository: ambient-code/platform
Length of output: 315
🏁 Script executed:
#!/bin/bash
# Verify MCPCredentialCard and use-mcp-credentials are truly unused
echo "=== Searching for MCPCredentialCard imports ==="
rg -n "MCPCredentialCard" -t ts
echo -e "\n=== Searching for use-mcp-credentials imports ==="
rg -n "use-mcp-credentials" -t ts
echo -e "\n=== Searching for mcp-credentials API imports ==="
rg -n "from.*mcp-credentials" -t ts
echo -e "\n=== Checking if files still exist ==="
find . -name "mcp-credential-card.tsx" -o -name "use-mcp-credentials.ts" -o -name "mcp-credentials.ts" 2>/dev/null | head -20Repository: ambient-code/platform
Length of output: 882
Clean up orphaned MCP credential code.
The simplified grid layout looks correct. However, removing MCPCredentialCard usage here leaves dead code that should be deleted in this PR:
components/frontend/src/components/mcp-credential-card.tsx— no longer imported anywherecomponents/frontend/src/services/queries/use-mcp-credentials.ts— only imported by the removed componentcomponents/frontend/src/services/api/mcp-credentials.ts— only imported by the removed hook
Leaving this code increases maintenance burden and may confuse future developers.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@components/frontend/src/app/integrations/IntegrationsClient.tsx` around lines
36 - 56, Remove the now-orphaned MCP-related code: delete the MCPCredentialCard
component, the useMcpCredentials hook, and the mcp-credentials API module;
ensure there are no remaining imports of MCPCredentialCard, useMcpCredentials,
or the mcp-credentials API across the codebase (remove from any barrel exports),
and run the build/type-check to confirm nothing else references those symbols.
2 participants
No description provided.