mergify: remove coderabbit comment requirement#941
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoves the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can use your project's `golangci-lint` configuration to improve the quality of Go code reviews.Add a configuration file to your project to customize how CodeRabbit runs |
|
Hey, something to think about - we will need to find a type of PR that we
are ok auto merging. Are there stats collected from mergify that we could
learn from?
…-- Jeremy Eder (he/him/his)
On Tue, Mar 17, 2026, 10:39 Ken Dreyer ***@***.***> wrote:
CodeRabbit does not leave a review if there are no actionable comments.
When Mergify does not see the CodeRabbit review, it will not merge the PR,
even if the PR meets all the other criteria (successful human review +
passing tests).
The purpose of adding coderabbit to the Mergify criteria is to provide a
natural quality governer: to ensure that humans read the reviews. Turns out
CodeRabbit is useful enough that we don't need to enforce this with
Mergify, and tweaking it further is not worth optimizing.
Fixes: #940 <#940>
------------------------------
You can view, comment on, or merge this pull request online at:
#941
Commit Summary
- 37e6fad
<37e6fad>
mergify: remove coderabbit comment requirement
File Changes
(1 file <https://github.com/ambient-code/platform/pull/941/files>)
- *M* .mergify.yml
<https://github.com/ambient-code/platform/pull/941/files#diff-6a30e47dd51449847422017b16878889b848f6602ac56d5a2e67ce8a19afade2>
(2)
Patch Links:
- https://github.com/ambient-code/platform/pull/941.patch
- https://github.com/ambient-code/platform/pull/941.diff
—
Reply to this email directly, view it on GitHub
<#941>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOUVGHX7KSPT355CUDKPBL4RGEVNAVCNFSM6AAAAACWU6K3IGVHI2DSMVQWIX3LMV43ASLTON2WKOZUGA4TAMJQGIZTCMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
CodeRabbit does not leave a review if there are no actionable comments. When Mergify does not see the CodeRabbit review, it will not merge the PR, even if the PR meets all the other criteria (successful human review + passing tests). The purpose of adding coderabbit to the Mergify criteria is to provide a natural quality governer: to ensure that humans read the reviews. Turns out CodeRabbit is useful enough that we don't need to enforce this with Mergify, and tweaking it further is not worth optimizing.
37e6fad to
1be956e
Compare
| - "#approved-reviews-by>=2" | ||
| - "#changes-requested-reviews-by=0" | ||
| - check-success=End-to-End Tests | ||
| - commented-reviews-by=coderabbitai[bot] |
There was a problem hiding this comment.
It's too bad there isn't a generic commented-on-by that counts any comment, not just review comments.
|
@Mergifyio queue |
Merge Queue Status
Required conditions to enter a queue
|
CodeRabbit does not leave a review if there are no actionable comments. When Mergify does not see the CodeRabbit review, it will not merge the PR, even if the PR meets all the other criteria (successful human review + passing tests).
The purpose of adding coderabbit to the Mergify criteria is to provide a natural quality governer: to ensure that humans read the reviews. Turns out CodeRabbit is useful enough that we don't need to enforce this with Mergify, and tweaking it further is not worth optimizing.
Fixes: #940