Skip to content

mergify: remove coderabbit comment requirement#941

Merged
ktdreyer merged 1 commit intomainfrom
kdreyer/mergify-coderabbit
Mar 18, 2026
Merged

mergify: remove coderabbit comment requirement#941
ktdreyer merged 1 commit intomainfrom
kdreyer/mergify-coderabbit

Conversation

@ktdreyer
Copy link
Contributor

@ktdreyer ktdreyer commented Mar 17, 2026

CodeRabbit does not leave a review if there are no actionable comments. When Mergify does not see the CodeRabbit review, it will not merge the PR, even if the PR meets all the other criteria (successful human review + passing tests).

The purpose of adding coderabbit to the Mergify criteria is to provide a natural quality governer: to ensure that humans read the reviews. Turns out CodeRabbit is useful enough that we don't need to enforce this with Mergify, and tweaking it further is not worth optimizing.

Fixes: #940

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 16be7c77-434f-49a4-97c4-54269379aff2

📥 Commits

Reviewing files that changed from the base of the PR and between 37e6fad and 1be956e.

📒 Files selected for processing (1)
  • .mergify.yml
💤 Files with no reviewable changes (1)
  • .mergify.yml

Walkthrough

Removes the commented-reviews-by=coderabbitai[bot] condition from the queue_conditions of the large-pr and default queues in .mergify.yml, dropping the bot review/comment requirement while leaving other checks unchanged.

Changes

Cohort / File(s) Summary
Mergify configuration
.mergify.yml
Deleted commented-reviews-by=coderabbitai[bot] from queue_rules for large-pr and default, removing the bot review gating condition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the CodeRabbit comment requirement from Mergify configuration.
Description check ✅ Passed The description provides relevant context about the change, explaining why CodeRabbit was originally added to Mergify and why it is no longer necessary.
Linked Issues check ✅ Passed The PR successfully addresses the objective in linked issue #940 by removing the commented-reviews-by=coderabbitai[bot] condition from .mergify.yml.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of removing the CodeRabbit requirement from Mergify configuration with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kdreyer/mergify-coderabbit
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use your project's `golangci-lint` configuration to improve the quality of Go code reviews.

Add a configuration file to your project to customize how CodeRabbit runs golangci-lint.

@jeremyeder
Copy link
Contributor

jeremyeder commented Mar 17, 2026 via email

CodeRabbit does not leave a review if there are no actionable comments.
When Mergify does not see the CodeRabbit review, it will not merge the
PR, even if the PR meets all the other criteria (successful human review
+ passing tests).

The purpose of adding coderabbit to the Mergify criteria is to provide a
natural quality governer: to ensure that humans read the reviews. Turns
out CodeRabbit is useful enough that we don't need to enforce this with
Mergify, and tweaking it further is not worth optimizing.
@ktdreyer ktdreyer force-pushed the kdreyer/mergify-coderabbit branch from 37e6fad to 1be956e Compare March 17, 2026 21:39
@ambient-code ambient-code bot added this to the Review Queue milestone Mar 18, 2026
- "#approved-reviews-by>=2"
- "#changes-requested-reviews-by=0"
- check-success=End-to-End Tests
- commented-reviews-by=coderabbitai[bot]
Copy link
Contributor

@mprpic mprpic Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too bad there isn't a generic commented-on-by that counts any comment, not just review comments.

@ktdreyer
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link

mergify bot commented Mar 18, 2026

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Required conditions to enter a queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue default]:
      • #approved-reviews-by >= 1 [🛡 GitHub repository ruleset rule protect-main]
      • #approved-reviews-by>=1
      • #changes-requested-reviews-by = 0 [🛡 GitHub repository ruleset rule protect-main]
      • #changes-requested-reviews-by=0
      • check-success=End-to-End Tests
      • check-success=test-local-dev-simulation
      • check-success=validate-manifests
    • all of [📌 queue conditions of queue large-pr]:
      • #approved-reviews-by>=2
      • #approved-reviews-by >= 1 [🛡 GitHub repository ruleset rule protect-main]
      • #changes-requested-reviews-by = 0 [🛡 GitHub repository ruleset rule protect-main]
      • #changes-requested-reviews-by=0
      • check-success=End-to-End Tests
      • check-success=test-local-dev-simulation
      • check-success=validate-manifests

@ktdreyer ktdreyer merged commit 577905a into main Mar 18, 2026
8 checks passed
@ktdreyer ktdreyer deleted the kdreyer/mergify-coderabbit branch March 18, 2026 20:04
@ambient-code ambient-code bot removed this from the Review Queue milestone Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coderabbit reviews should not gate mergify auto-merges

3 participants