deps(runner): bump anthropic 0.86.0, claude-agent-sdk 0.1.50#985
deps(runner): bump anthropic 0.86.0, claude-agent-sdk 0.1.50#985jeremyeder merged 3 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
WalkthroughRaised ambient-runner optional Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
SDK Feature Analysis
TL;DR
Action Required
Opt-in Features to EvaluateThese are available but require code changes to adopt:
Notable Bug Fixes (claude-agent-sdk)
anthropic SDK Highlights (0.68.0 -> 0.86.0)
Bundled Claude CLI versions (27 releases)
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/runners/ambient-runner/pyproject.toml`:
- Around line 23-24: The code still uses the deprecated max_thinking_tokens
option; change all usages to the new thinking config pattern (ThinkingConfig or
ThinkingConfig*) before bumping claude-agent-sdk to >=0.1.50: in
ag_ui_claude_sdk.config (where max_thinking_tokens is defined/loaded) replace
that field with a thinking object built from the SDK's ThinkingConfig* type, and
in ag_ui_claude_sdk.adapter (where max_thinking_tokens is passed, e.g., at the
call site around line 140) construct and pass the corresponding
thinking=ThinkingConfig(...) instance instead of max_thinking_tokens; ensure
imports for the SDK ThinkingConfig type are added/updated and any tests or
defaults are adjusted to the new structure so runtime startup uses thinking
consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 389f4991-fe11-4313-8c1d-313d97211942
⛔ Files ignored due to path filters (1)
components/runners/ambient-runner/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
components/runners/ambient-runner/pyproject.toml
| "anthropic[vertex]>=0.86.0", | ||
| "claude-agent-sdk>=0.1.50", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== 1) Find deprecated option usage =="
rg -n -C2 '\bmax_thinking_tokens\b' -g '!**/tests/**' || true
echo
echo "== 2) Find new thinking config usage/imports =="
rg -n -C2 '\bThinkingConfig(Adaptive|Enabled|Disabled)\b|\bthinking\s*=' -g '!**/tests/**' || true
echo
echo "== 3) Find claude-agent-sdk callsites/options objects for manual inspection =="
rg -n -C3 'ClaudeAgentOptions|claude-agent-sdk|create_session|session|thinking' components/runners/ambient-runner || trueRepository: ambient-code/platform
Length of output: 50378
Migrate max_thinking_tokens to thinking config before merging claude-agent-sdk>=0.1.50.
The codebase still references the deprecated max_thinking_tokens parameter in ag_ui_claude_sdk/config.py (line 19) and ag_ui_claude_sdk/adapter.py (line 140), but the SDK version bump to >=0.1.50 removes support for this option. Update all usages to the new thinking + ThinkingConfig* pattern to prevent startup errors or runtime incompatibility.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@components/runners/ambient-runner/pyproject.toml` around lines 23 - 24, The
code still uses the deprecated max_thinking_tokens option; change all usages to
the new thinking config pattern (ThinkingConfig or ThinkingConfig*) before
bumping claude-agent-sdk to >=0.1.50: in ag_ui_claude_sdk.config (where
max_thinking_tokens is defined/loaded) replace that field with a thinking object
built from the SDK's ThinkingConfig* type, and in ag_ui_claude_sdk.adapter
(where max_thinking_tokens is passed, e.g., at the call site around line 140)
construct and pass the corresponding thinking=ThinkingConfig(...) instance
instead of max_thinking_tokens; ensure imports for the SDK ThinkingConfig type
are added/updated and any tests or defaults are adjusted to the new structure so
runtime startup uses thinking consistently.
Address CodeRabbit review feedback on PR #985: add the new `thinking` config (adaptive/enabled/disabled) to ALLOWED_FORWARDED_PROPS so clients can use the preferred API alongside the legacy `max_thinking_tokens` option. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Address CodeRabbit review feedback on PR #985: add the new `thinking` config (adaptive/enabled/disabled) to ALLOWED_FORWARDED_PROPS so clients can use the preferred API alongside the legacy `max_thinking_tokens` option. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2482dc1 to
5ed09ec
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/runners/ambient-runner/ag_ui_claude_sdk/adapter.py`:
- Around line 1134-1137: The end-event yields are missing the reasoning message
identifier causing clients to orphan in-flight reasoning blocks; update the two
yields that produce ReasoningMessageEndEvent and ReasoningEndEvent (around the
symbols thread_id, run_id, ts) to include the message identifier field
(messageId or message_id as used elsewhere in this module) so the emitted end
events match the start events' ID; locate the block emitting
ReasoningMessageEndEvent and ReasoningEndEvent and add messageId=message_id (or
the correct local variable name) to both event constructors.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8feba351-e733-49a6-ab46-5be02e37664b
⛔ Files ignored due to path filters (1)
components/runners/ambient-runner/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
components/runners/ambient-runner/ag_ui_claude_sdk/adapter.pycomponents/runners/ambient-runner/ag_ui_claude_sdk/config.pycomponents/runners/ambient-runner/pyproject.toml
Bump SDK dependencies for the ambient runner: - anthropic[vertex]: 0.68.0 -> 0.86.0 - claude-agent-sdk: 0.1.23 -> 0.1.50 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address CodeRabbit review feedback on PR #985: add the new `thinking` config (adaptive/enabled/disabled) to ALLOWED_FORWARDED_PROPS so clients can use the preferred API alongside the legacy `max_thinking_tokens` option. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add messageId to reasoning cleanup end events so clients can correlate start/end events and avoid orphaning in-flight reasoning blocks - Auto-migrate deprecated max_thinking_tokens to ThinkingConfigEnabled in forwarded_props for forward compatibility with SDK changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2530986 to
754c748
Compare
…-code#985) ## Summary - Bump `anthropic[vertex]`: 0.68.0 → 0.86.0 - Bump `claude-agent-sdk`: 0.1.23 → 0.1.50 - Lockfile regenerated via `uv lock` ## Test plan - [ ] Runner pod starts successfully with new SDK versions - [ ] Claude session creation and streaming works end-to-end - [ ] Vertex AI (Gemini) path unaffected by anthropic bump - [ ] No import errors or deprecation warnings at startup 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Ambient Code Bot <bot@ambient-code.local> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Summary
anthropic[vertex]: 0.68.0 → 0.86.0claude-agent-sdk: 0.1.23 → 0.1.50uv lockTest plan
🤖 Generated with Claude Code