Skip to content

Bugfix workflow: Add linting/formatting step after test phase #56

@kami619

Description

@kami619

Problem

The agent ran linters (black, isort, ruff) during the /fix phase on the main code changes, but forgot to re-run formatters after adding regression tests in the /test phase. This resulted in formatting violations that required manual correction via screenshots from the user.

Impact

  • Additional manual intervention required
  • Formatting issues discovered during PR review rather than being caught automatically
  • Inconsistent code formatting in commits

Context

This issue was identified during the bugfix session for ambient-code/agentready#306 addressing ambient-code/agentready#302.

Recommended Solution

The bugfix workflow should:

  • Add an explicit formatting step in the /test phase after writing regression tests
  • Include guidance to run black, isort, and ruff on all modified files (both source and test files)
  • Consider adding a checklist: "Run formatters on all modified files before committing"

Alternatively, could add a general "pre-commit checks" step that runs before any git operations.

Reference

From PR comment: #42 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions