-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Description
Problem
The agent ran linters (black, isort, ruff) during the /fix phase on the main code changes, but forgot to re-run formatters after adding regression tests in the /test phase. This resulted in formatting violations that required manual correction via screenshots from the user.
Impact
- Additional manual intervention required
- Formatting issues discovered during PR review rather than being caught automatically
- Inconsistent code formatting in commits
Context
This issue was identified during the bugfix session for ambient-code/agentready#306 addressing ambient-code/agentready#302.
Recommended Solution
The bugfix workflow should:
- Add an explicit formatting step in the
/testphase after writing regression tests - Include guidance to run
black,isort, andruffon all modified files (both source and test files) - Consider adding a checklist: "Run formatters on all modified files before committing"
Alternatively, could add a general "pre-commit checks" step that runs before any git operations.
Reference
From PR comment: #42 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels