Cleanup the Django 1.8 deprecation warnings #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 10, 2015 16:38
RemovedInDjango19Warning: django.contrib.contenttypes.generic is deprecated and will be removed in Django 1.9. Its contents have been moved to the fields, forms, and admin submodules of django.contrib.contenttypes
accordingly. RemovedInDjango19Warning: import_by_path() has been deprecated. Use import_string() instead.
RemovedInDjango19Warning: Model class dynamic_initial_data.models.RegisteredForDeletionReceipt doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9. If using: from dynamic_initial_data import BaseInitialData Need to update to: from dynamic_initial_data.base import BaseInitialData
Contributor
There was a problem hiding this comment.
What is the reason for removing this? I'm open to removing it, but it's a pretty big change that will affect a lot of dependencies
Author
There was a problem hiding this comment.
Did you see my commit message? minervaproject@1647e68
Having something imported in a init.py file will cause the message "was imported before its application was loaded"
wesleykendall
added a commit
that referenced
this pull request
Jun 12, 2015
Cleanup the Django 1.8 deprecation warnings
Contributor
|
Your changes have been published to pypi under version 0.5.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.