Add snapshot of trace with roctx regions for the Fortran Jacobi example #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@gsitaram I was not aware that you added this Fortran OMP README with markers, it looks great! One minor suggestion is to add at the top of the README a ROCm version that you used, especially since I think that the described approach works only starting from 6.4 or even later. As you know many trainings and users still have to rely on older ROCm versions, so they would need to make some adaptations to make this example work in their environment... |
Collaborator
Author
|
@lstanisi-amd , I had used the rocm afar drop for this exercise. Added the version for this in the README now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.