-
Notifications
You must be signed in to change notification settings - Fork 57
Fix missing packages, broken entry points, and add packaging CI tests #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 5 missing packages to setup.py (gaia.vlm, gaia.apps.docker, gaia.apps.jira, gaia.apps.summarize.templates, gaia.eval.fix_code_testbench) - Create missing __init__.py for gaia.mcp, gaia.eval, gaia.talk, gaia.apps.summarize - Add main() to mcp_bridge.py for gaia-mcp entry point - Remove broken gaia-mcp-atlassian entry point (file doesn't exist) - Remove dead ChatApp import from agents/__init__.py - Add test_packaging.py with 6 CI tests to catch packaging issues - Remove unused sd_agent_example.py
The github-release job in pypi.yml used gh release create with --notes "", which blanked out release notes if publish_installer.yml had already created the release. Now it checks if the release exists first and only creates as a fallback with --generate-notes.
kovtcharov-amd
approved these changes
Feb 5, 2026
- Add pre-existing warning codes to DISABLED_CHECKS in util/lint.py - Fix unused variable warnings in batch_experiment.py (prefix with _) - Fix f-strings without interpolation in batch_experiment.py - Fix trailing whitespace and encoding in eval.py
Add system prompt to make LLM recall facts more reliably. Also made prompts more explicit about expected answers to reduce non-determinism.
LLM responses are non-deterministic, so the memory recall test may occasionally fail. Added retry logic (up to 3 attempts) to make the test more robust while still validating conversation memory works.
Tell LLM to answer directly and never ask questions back. If it doesn't know, it should say 'I don't know' instead of asking clarifying questions.
Previously, if user answered 'n' to installing Lemonade, init would stop at step 1/4. Now it continues to step 2 (server health check) which will verify connectivity regardless of how Lemonade is set up: - Remote server via LEMONADE_BASE_URL - Manual local installation - Pre-existing installation The health check is the proper gate, not the installation prompt.
This was referenced Feb 5, 2026
Closed
The 'If you don't know the answer, say I don't know' instruction was causing the small 0.6B model to respond with 'I don't know' even when the answer was in conversation history. Small models can't distinguish between inherent knowledge gaps vs context-provided information. Simplified to 'answer based on conversation history' which works with both small and large models.
- Fix pylint issues in eval.py, groundtruth.py, and all MCP files (unused vars, f-strings, missing encoding, duplicate exceptions, etc.) - Add inline pylint disable for exec-used in blender_mcp_server.py - Remove unused import from test_chat_sdk.py (flake8 F401) - Re-enable 13 pylint checks in lint.py now that violations are fixed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…#309) ## Summary Fixes package registration issues that caused `ModuleNotFoundError` on non-editable installs, plus CI improvements and bug fixes. **Version bump**: v0.15.3.1 → v0.15.3.2 ### Package Registration Fixes - Add 5 missing packages to setup.py (`gaia.vlm`, `gaia.apps.docker`, `gaia.apps.jira`, `gaia.apps.summarize.templates`, `gaia.eval.fix_code_testbench`) - Create missing `__init__.py` for `gaia.mcp`, `gaia.eval`, `gaia.talk`, `gaia.apps.summarize` ### Entry Point Fixes - Add `main()` to `mcp_bridge.py` so `gaia-mcp` entry point works - Remove broken `gaia-mcp-atlassian` entry point (file doesn't exist) ### Bug Fixes - **Fix `gaia init` blocking on Lemonade install**: Previously stopped at step 1/4 if user declined installation. Now continues to step 2 (health check) which properly verifies connectivity for remote servers, manual installs, or `LEMONADE_BASE_URL` setups. ### Code Cleanup - Remove dead `ChatApp` import from `agents/__init__.py` - Fix unused variable warnings in `batch_experiment.py` - Fix trailing whitespace and encoding in `eval.py` - Re-enable 13 pylint checks after fixing all violations ### CI Improvements - **Fix release notes bug**: `pypi.yml` was overwriting release notes with empty string due to race condition with `publish_installer.yml`. Now checks if release exists before creating. - **Add packaging integrity tests**: New `test_packaging.py` with 6 tests to catch missing packages, `__init__.py` files, and broken entry points - **Update lint config**: Add pre-existing warning codes to `DISABLED_CHECKS` (exposed when new `__init__.py` files made pylint scan `gaia.eval` and `gaia.mcp`) - **Fix flaky chat SDK memory test**: The 'say I don't know' system prompt instruction was confusing the small 0.6B model - it would say 'I don't know' even when the answer was in conversation history. Changed to 'answer based on conversation history' which works reliably. ### Release Notes - Added `docs/releases/v0.15.3.2.mdx` with full release notes - Updated `docs/docs.json` navbar to show v0.15.3.2 · Lemonade 9.3.0 ## Test plan - [x] All 316 unit tests pass locally - [x] New `test_packaging.py` (6 tests) validates package/entry point integrity - [x] `util/lint.py --all` passes (5 passed, 2 non-blocking warnings) - [ ] CI runs packaging tests before other unit tests - [ ] Chat SDK integration tests pass --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agents
Agent system changes
dependencies
Dependency updates
devops
DevOps/infrastructure changes
documentation
Documentation changes
eval
Evaluation framework changes
mcp
MCP integration changes
performance
Performance-critical changes
talk
Talk agent changes
tests
Test changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes package registration issues that caused
ModuleNotFoundErroron non-editable installs, plus CI improvements and bug fixes.Version bump: v0.15.3.1 → v0.15.3.2
Package Registration Fixes
gaia.vlm,gaia.apps.docker,gaia.apps.jira,gaia.apps.summarize.templates,gaia.eval.fix_code_testbench)__init__.pyforgaia.mcp,gaia.eval,gaia.talk,gaia.apps.summarizeEntry Point Fixes
main()tomcp_bridge.pysogaia-mcpentry point worksgaia-mcp-atlassianentry point (file doesn't exist)Bug Fixes
gaia initblocking on Lemonade install: Previously stopped at step 1/4 if user declined installation. Now continues to step 2 (health check) which properly verifies connectivity for remote servers, manual installs, orLEMONADE_BASE_URLsetups.Code Cleanup
ChatAppimport fromagents/__init__.pybatch_experiment.pyeval.pyCI Improvements
pypi.ymlwas overwriting release notes with empty string due to race condition withpublish_installer.yml. Now checks if release exists before creating.test_packaging.pywith 6 tests to catch missing packages,__init__.pyfiles, and broken entry pointsDISABLED_CHECKS(exposed when new__init__.pyfiles made pylint scangaia.evalandgaia.mcp)Release Notes
docs/releases/v0.15.3.2.mdxwith full release notesdocs/docs.jsonnavbar to show v0.15.3.2 · Lemonade 9.3.0Test plan
test_packaging.py(6 tests) validates package/entry point integrityutil/lint.py --allpasses (5 passed, 2 non-blocking warnings)