Conversation
- Extract _ensure_webui_built() to gaia/ui/build.py shared module to avoid circular import risk when init_command.py calls it - Add frontend build step to gaia init (dev/source installs only) - Keep auto-rebuild at gaia --ui launch as staleness safety net - Fix Agent UI docs to clarify Setup -> Quickstart -> Agent UI chain - Add unit tests for all new code paths
When installed via npm, the Python server now reads GAIA_WEBUI_DIST to locate the pre-built frontend shipped inside the npm package. Falls back to default path for source/dev installs. Closes the JSON error users hit when running gaia-ui after npm install -g @amd-gaia/agent-ui.
- A1: Add warn_fn parameter to ensure_webui_built() so warning/error messages route through log.warning instead of log.info; update cli.py and init_command.py callers accordingly - A2: Add test for npm run build CalledProcessError being caught and returning False - A3: Add test for node-found/npm-missing code path warning and skip - A4: ensure_webui_built() now returns bool (True=success/up-to-date, False=skipped/failed); init only prints "Agent UI frontend ready" when build actually succeeded; _call helper updated to capture and return the bool so all tests verify the contract - A5: Clarify "from the repo root" in manual build commands across two locations in docs/guides/agent-ui.mdx
Replace the environment variable mechanism for specifying the frontend dist directory with an explicit --ui-dist CLI argument. This avoids implicit env var coupling between gaia-ui and the Python server. - Add --ui-dist to top-level and chat subcommand parsers in cli.py - Add webui_dist parameter to _launch_agent_ui() and create_app() - Pass --ui-dist via spawn args in gaia-ui.mjs instead of env override - Add --ui-dist to standalone server.py main() runner - Clarify per-scenario restart commands in agent-ui.mdx accordion - Rewrite test to use webui_dist parameter directly (no module reload)
github-actions
Bot
added
documentation
Collaborator
Author
|
Closing — release branch was incorrectly based on the feature branch rather than main. Opening a separate PR for the feature work first; release PR will follow from main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release v0.17.1 — automatic Agent UI frontend build during
gaia init,--ui-distCLI argument, and CI/publishing pipeline hardening.Files Changed
docs/releases/v0.17.1.mdx— Release notes (new file)docs/docs.json— Addedreleases/v0.17.1to Releases tab, updated navbar tov0.17.1 · Lemonade 10.0.0src/gaia/version.py—0.17.1-rc.1→0.17.1src/gaia/apps/webui/package.json—0.17.1-rc.1→0.17.1Release Highlights
Improvements:
gaia init— Dev/source installs now build the frontend automatically, eliminating the manualnpm install && npm run buildstep. Sharedgaia/ui/build.pymodule with staleness detection and graceful fallback (commit f89810a)--ui-distCLI flag —gaia chat --uiand the UI server accept--ui-dist <path>for custom frontend dist directories, replacing theGAIA_WEBUI_DISTenvironment variable (commits f3af9b2, 1fa2096)CI/Infrastructure:
Post-Merge
After merging:
CI: validate-release → publish-release → PyPI (gated on Kalin approval).
Test plan
python3 util/validate_release_notes.py docs/releases/v0.17.1.mdx --tag v0.17.1passesdocs/docs.jsonis valid JSON andreleases/v0.17.1appears first in Releases tabsrc/gaia/version.pyreads0.17.1src/gaia/apps/webui/package.jsonreads0.17.1