NicPlugin update

[alexandraBara]

Summary

• Avoiding errors when card is not present, plugin with error out with NOT_RAN.

Test plan

• pytest test/unit
• pytest test/functional (if applicable)
• pre-commit run --all-files

Checklist

• Added/updated tests (or explained why not)
• Updated docs/README if behavior changed
• No secrets or credentials committed

Before:

(venv) alexbara@smci355-ccs-aus-n13-25:~/node-scraper$ node-scraper run-plugins NetworkPlugin NicPlugin RdmaPlugin
  2026-05-19 16:15:04 UTC       INFO               nodescraper | Log path: ./scraper_logs_smci355_ccs_aus_n13_25_prov_aus_ccs_cpe_ice_amd_com_2026_05_19-04_15_04_PM
  2026-05-19 16:15:04 UTC       INFO               nodescraper | System Name: smci355-ccs-aus-n13-25.prov.aus.ccs.cpe.ice.amd.com
  2026-05-19 16:15:04 UTC       INFO               nodescraper | System location: SystemLocation.LOCAL
  2026-05-19 16:15:04 UTC       INFO               nodescraper | Initializing connection manager for InBandConnectionManager with default args
  2026-05-19 16:15:04 UTC       INFO               nodescraper | --------------------------------------------------
  2026-05-19 16:15:04 UTC       INFO               nodescraper | Running plugin NetworkPlugin
  2026-05-19 16:15:04 UTC       INFO               nodescraper | Initializing connection: InBandConnectionManager
  2026-05-19 16:15:04 UTC       INFO               nodescraper | Using local shell
  2026-05-19 16:15:04 UTC       INFO               nodescraper | Checking OS family
  2026-05-19 16:15:04 UTC       INFO               nodescraper | OS Family: LINUX
  2026-05-19 16:15:04 UTC       INFO               nodescraper | Running data collector: NetworkCollector
  2026-05-19 16:15:05 UTC       INFO               nodescraper | (NetworkPlugin) Network data collected successfully
  2026-05-19 16:15:05 UTC       INFO               nodescraper | Running data analyzer: NetworkAnalyzer
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:15:05 UTC      ERROR               nodescraper | (NetworkPlugin) Network errors detected in statistics (16 errors: Ethtool error detected: rx_fec_uncorrectable_blocks (x8), Ethtool error detected: rx_filter_miss (x8))
  2026-05-19 16:15:05 UTC       INFO               nodescraper | --------------------------------------------------
  2026-05-19 16:15:05 UTC       INFO               nodescraper | Running plugin NicPlugin
  2026-05-19 16:15:05 UTC       INFO               nodescraper | Running data collector: NicCollector
  2026-05-19 16:15:06 UTC       INFO               nodescraper | (NicPlugin) Collected 55 niccli/nicctl command results (30 warnings: niccli/nicctl command failed: nicctl --version, niccli/nicctl command failed: nicctl show card flash partition --json, niccli/nicctl
 ...
 command failed: nicctl show port, niccli/nicctl command failed: nicctl show qos, niccli/nicctl command failed: nicctl show rdma statistics, niccli/nicctl command failed: nicctl show version host-software)
  2026-05-19 16:15:06 UTC       INFO               nodescraper | Running data analyzer: NicAnalyzer
  2026-05-19 16:15:06 UTC       INFO               nodescraper | (NicPlugin) Broadcom support_rdma, performance_profile, pcie_relaxed_ordering, getqos, and nicctl card logs checks OK

After:

(venv) alexbara@smci355-ccs-aus-n13-25:~/node-scraper$ node-scraper run-plugins NetworkPlugin NicPlugin RdmaPlugin
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Log path: ./scraper_logs_smci355_ccs_aus_n13_25_prov_aus_ccs_cpe_ice_amd_com_2026_05_19-04_14_12_PM
  2026-05-19 16:14:12 UTC       INFO               nodescraper | System Name: smci355-ccs-aus-n13-25.prov.aus.ccs.cpe.ice.amd.com
  2026-05-19 16:14:12 UTC       INFO               nodescraper | System location: SystemLocation.LOCAL
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Initializing connection manager for InBandConnectionManager with default args
  2026-05-19 16:14:12 UTC       INFO               nodescraper | --------------------------------------------------
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Running plugin NetworkPlugin
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Initializing connection: InBandConnectionManager
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Using local shell
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Checking OS family
  2026-05-19 16:14:12 UTC       INFO               nodescraper | OS Family: LINUX
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Running data collector: NetworkCollector
  2026-05-19 16:14:12 UTC       INFO               nodescraper | (NetworkPlugin) Network data collected successfully
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Running data analyzer: NetworkAnalyzer

...
  2026-05-19 16:14:12 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:14:12 UTC      ERROR               nodescraper | Ethtool error detected: rx_fec_uncorrectable_blocks
  2026-05-19 16:14:12 UTC      ERROR               nodescraper | Ethtool error detected: rx_filter_miss
  2026-05-19 16:14:12 UTC      ERROR               nodescraper | (NetworkPlugin) Network errors detected in statistics (16 errors: Ethtool error detected: rx_fec_uncorrectable_blocks (x8), Ethtool error detected: rx_filter_miss (x8))
  2026-05-19 16:14:12 UTC       INFO               nodescraper | --------------------------------------------------
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Running plugin NicPlugin
  2026-05-19 16:14:12 UTC       INFO               nodescraper | Running data collector: NicCollector
  2026-05-19 16:14:14 UTC       INFO               nodescraper | (NicPlugin) Collected 35 niccli/nicctl command results
  2026-05-19 16:14:14 UTC       INFO               nodescraper | Running data analyzer: NicAnalyzer
  2026-05-19 16:14:14 UTC       INFO               nodescraper | (NicPlugin) Broadcom support_rdma, performance_profile, pcie_relaxed_ordering, getqos, and nicctl card logs checks OK