Pytorch based Finetuning LLMs (PEFT)#78
Merged
iswaryaalex merged 25 commits intomainfrom Mar 11, 2026
Merged
Conversation
Collaborator
|
Nice - overall looks decent. Couple thoughts:
|
danielholanda
approved these changes
Mar 5, 2026
Collaborator
danielholanda
left a comment
There was a problem hiding this comment.
Reviewed and tested on Windows! Worked great.
Please wait for Adam's review before merging.
adamlam2-amd
requested changes
Mar 6, 2026
Collaborator
adamlam2-amd
left a comment
There was a problem hiding this comment.
Please address Daniel's comments as well as the comment I left above.
Otherwise, most of it looks good. Will retest when QA sees it.
Collaborator
Author
|
@danielholanda Adding a hidden test to do single run of lora (model loading, dataset loading and 1 iteration) with a timeout |
Collaborator
Author
|
@adamlam2-amd Thanks for the review. My key changes are
|
Collaborator
|
@adamlam2-amd Anything else you would like to see here before approving? |
…alo_playbooks into iswarya/pytorch-finetuning
Collaborator
Author
|
Alright! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR brings in Pytorch Finetuning playbooks that focus of PEFT techniques like SFT full-finetuning, LoRA and QLoRA using pytorch with ROCm backend
assets: train_full_finetuning, train_lora.py and train_qlora.pyREADMEto walk through the different techniques, overview, comparison , details, how to finetune, how to customize and finally how to use the finetuned models/adapters