Merged
Conversation
84b3e44 to
fdab0cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typedstruct,png,toml, and rewriteserialstubs for self-contained resolutionDetails
Python version & dependency upgrades
All pinned dependencies have been bumped to current releases with flexible version ranges:
Removed
python-language-server(unmaintained, not needed).pyre type checking (159 → 0 errors)
.pyre_configurationto usesite-packagesearch paths for all third-party deps and excludefrontend/stubs/typedstruct/__init__.pyi,stubs/png/__init__.pyi,stubs/toml/__init__.pyistubs/serial/__init__.pyito be fully self-contained (no broken submodule imports)mariner/server/api.pyreturn types toUnion[str, Response]for Flask 3.x compatibilitynone_throws()for proper type narrowing on nullable file uploads# pyre-fixmecomments fromprinter.pyandtest_mars.pyTest fixes
assertEquals→assertEqual(removed in Python 3.12)setUpPyfakefs(additional_skip_names=["importlib.metadata"])to prevent pyfakefs from breaking Flask's werkzeug version lookup_get_config.cache_clear()before fake filesystem setup to avoid stale LRU-cached configfreezegunbumped to ^1.4 for Python 3.13 support (uuid._uuid_generate_timewas removed)Lint fixes
node_modulesto.flake8exclude list (new flake8 was picking up vendored Python in node_modules)# noqa: E701for inline exception class definitions (black/flake8 disagreement)CI workflow
["3.8", "3.9", "3.10"]→["3.11", "3.12", "3.13"]matrix.python-version == '3.11'Test plan
poetry run flake8— 0 errorspoetry run black --check .— 0 reformats neededpoetry run pyre check— 0 type errorspoetry run green— 69/69 tests pass