This repository was archived by the owner on May 15, 2024. It is now read-only.
chore(refactor): createOneAppExternals #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-forger
approved these changes
Oct 19, 2021
Matthew-Mallimo
approved these changes
Oct 19, 2021
10xLaCroixDrinker
added a commit
that referenced
this pull request
Oct 30, 2021
* chore(refactor): refactor createExternalsDllWebpackConfig function * chore(refactor): createOneAppExternals (#403) * chore(refactor): refactor webpack/config/bundles.js (#404) * chore(hmr): remove unused hot option * refactor(hmr): remove unused hot option in loaders Co-authored-by: Matthew Mallimo <matthew.mallimo@gmail.com> Co-authored-by: Jaime King <jimmy.king@aexp.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a general summary of your changes in the Title above.
Description
Describe your changes in detail
This project only accepts pull requests related to open issues.
If suggesting a new feature or change, please discuss it in an issue first.
Motivation
Why is this change required? What issue does it resolve?
Test Conditions
Describe in detail how the changes are tested.
Include details of your testing environment, and the tests you ran to.
How does your change affect the rest of the code.
Types of changes
Check boxes that apply:
Checklist
Check boxes that apply: