Propagate API DTO into PutApiSpecificationInApim and use base DTO for OpenAPI updates#1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
properties.Description
PutApiSpecificationInApimdelegate signature to accept aJsonObject baseDtoparameter and update all resolver and caller sites accordingly.ResolvePutApiSpecificationInApimand itsputOpenApiSpecificationhelper to operate on a clonedbaseDtoand merge the OpenAPIproperties.format/properties.valueinto it instead of fetching the DTO again from APIM.PutApiSpecificationInApimto pass the resource DTO (e.g. inputApi,putSpecification,putSpecificationfor workspace API, and integration/publisher tests).dtowhere appropriate.Testing
dotnet test src/publisher.testsand all tests passed after updates to fixtures and callers.dotnet test src/integration.testsand the adjusted test that exercises API specification uploads passed.Codex Task