Skip to content
This repository was archived by the owner on Apr 18, 2022. It is now read-only.

Comments

Add error printing and remove warnings from source#347

Merged
bors[bot] merged 1 commit intoamethyst:developfrom
Xaeroxe:audio_err_print
Sep 12, 2017
Merged

Add error printing and remove warnings from source#347
bors[bot] merged 1 commit intoamethyst:developfrom
Xaeroxe:audio_err_print

Conversation

@Xaeroxe
Copy link
Member

@Xaeroxe Xaeroxe commented Sep 12, 2017

This PR adds printing of any errors that may occur and also removes some of the code warnings

Fixes #346

@Xaeroxe Xaeroxe added team: audio status: ready type: improvement An improvement or change to an existing feature. labels Sep 12, 2017
@Xaeroxe Xaeroxe requested review from a team and torkleyy September 12, 2017 16:17
Copy link
Member

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xaeroxe
Copy link
Member Author

Xaeroxe commented Sep 12, 2017

bors r+

bors bot added a commit that referenced this pull request Sep 12, 2017
347: Add error printing and remove warnings from source r=Xaeroxe a=Xaeroxe

This PR adds printing of any errors that may occur and also removes some of the code warnings

Fixes #346
@bors
Copy link
Contributor

bors bot commented Sep 12, 2017

@bors bors bot merged commit 987c0d6 into amethyst:develop Sep 12, 2017
@Xaeroxe Xaeroxe deleted the audio_err_print branch September 12, 2017 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team: audio type: improvement An improvement or change to an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants