This repository was archived by the owner on Apr 18, 2022. It is now read-only.
[rs] 01: Decentralize asset formats#405
Merged
bors[bot] merged 4 commits intoamethyst:developfrom Oct 12, 2017
Merged
Conversation
torkleyy
added
project: restructure
type: improvement
Xaeroxe
approved these changes
Oct 11, 2017
Member
Xaeroxe
left a comment
Xaeroxe
left a comment
There was a problem hiding this comment.
This looks pretty good, got some nice reduction in hierarchy and makes the architecture simpler. More like this please! 👍
Rhuagh
approved these changes
Oct 11, 2017
AnneKitsune
approved these changes
Oct 11, 2017
Member
Author
|
ping @omni-viral |
zakarumych
previously requested changes
Oct 12, 2017
Member
zakarumych
left a comment
zakarumych
left a comment
There was a problem hiding this comment.
I really like how you rearrange stuff!
Just a little nit I've spotted 😄
Cargo.toml
Outdated
| gfx = "0.16" | ||
| genmesh = "0.4" | ||
| imagefmt = "4.0" | ||
| serde = "1" |
Member
There was a problem hiding this comment.
Dependencies are still shuffled a bit.
* Add amethyst_assets dependency to renderer * Add submodule to audio module
Member
Author
|
Okay fixed and rebased now. |
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 12, 2017
405: [rs] 01: Decentralize asset formats r=Xaeroxe a=torkleyy This PR (and several follow-ups) will slowly restructure Amethyst according to #396 ## Improvements * Don't wrap crates in the main crate (instead, more self-contained) * `amethyst_renderer` now depends on `amethyst_assets`
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (and several follow-ups) will slowly restructure Amethyst according to #396
Improvements
amethyst_renderernow depends onamethyst_assets