-
Notifications
You must be signed in to change notification settings - Fork 7
Refactor codebase to migrate from PyQt5 to QtPy and PySide2 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f4f6f13
bf40289
c6a8ba2
9988670
7f0c55f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import os | ||
|
|
||
| # Prefer the PySide6 backend when QtPy resolves the Qt binding. | ||
| os.environ.setdefault("QT_API", "pyside2") | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |||||
| import time | ||||||
| import traceback | ||||||
| from collections import deque | ||||||
| from typing import Iterable, Union | ||||||
|
|
||||||
| import numpy as np | ||||||
|
|
||||||
|
|
@@ -117,7 +118,7 @@ def __init__(self, period: float, signal_root_name: str): | |||||
| self.buffered_signals.add("robot_realtime::joints_state::positions") | ||||||
|
|
||||||
| # TODO: implement a logic to remove signals that are not needed anymore | ||||||
| def add_signals_to_buffer(self, signals: list | set | str): | ||||||
| def add_signals_to_buffer(self, signals: Union[str, Iterable[str]]): | ||||||
|
||||||
| def add_signals_to_buffer(self, signals: Union[str, Iterable[str]]): | |
| def add_signals_to_buffer(self, signals: str | Iterable[str]): |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment variable suggests PySide2, but the PR description mentions PyQt6. This inconsistency should be clarified - either the description should be updated to reflect PySide2 usage, or the backend preference should be changed to match the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the bot