Skip to content

Disable curve interactivity and point selection in real-time mode #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2025
Merged

Disable curve interactivity and point selection in real-time mode #114

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7328ef3
Disable curve interactivity and point selection in real-time mode
xela-95 Nov 28, 2025
a3cd8d8
Update robot_log_visualizer/plotter/pyqtgraph_viewer_canvas.py
xela-95 Nov 28, 2025
65a08ae
Apply suggestions from code review
xela-95 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion robot_log_visualizer/plotter/pyqtgraph_viewer_canvas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
import pyqtgraph as pg # type: ignore
from qtpy import QtCore, QtWidgets # type: ignore

from robot_log_visualizer.utils.utils import ColorPalette
from robot_log_visualizer.signal_provider.signal_provider import ProviderType
from robot_log_visualizer.utils.utils import ColorPalette

# ------------------------------------------------------------------------
# Type aliases
Expand Down Expand Up @@ -201,6 +201,11 @@ def _add_missing_curves(
symbol=None,
)

# For real-time mode, disable curve clickability to avoid interfering with live updates
if self._signal_provider.provider_type == ProviderType.REALTIME:
self._curves[key].setCurveClickable(False)
self._curves[key].setEnabled(False)

def _remove_obsolete_curves(self, paths: Sequence[Path]) -> None:
"""Delete curves that disappeared from *paths*."""
valid = {"/".join(p) for p in paths}
Expand Down Expand Up @@ -240,6 +245,10 @@ def _on_mouse_click(self, event) -> None: # noqa: N802
if event.button() != QtCore.Qt.MouseButton.LeftButton:
return # ignore other buttons

# Disable point selection / labels in realtime mode
if self._signal_provider.provider_type == ProviderType.REALTIME:
return

# Scene → data coordinates
scene_pos = event.scenePos()
if not self._plot.sceneBoundingRect().contains(scene_pos):
Expand Down