Skip to content

more complete RDP#136

Merged
silversword411 merged 1 commit intoamidaware:mainfrom
bbrendon:main
Apr 25, 2023
Merged

more complete RDP#136
silversword411 merged 1 commit intoamidaware:mainfrom
bbrendon:main

Conversation

@bbrendon
Copy link
Copy Markdown
Contributor

@bbrendon bbrendon commented Apr 5, 2023

No description provided.

@dinger1986
Copy link
Copy Markdown
Contributor

can we parameter this for username etc so it can be added, if its ignored then it doesnt set the username etc.

Also for the comments they would be better in a comment header at the top

@bbrendon
Copy link
Copy Markdown
Contributor Author

bbrendon commented Apr 5, 2023

I wasn’t really looking to rewrite it in powershell :)

@dinger1986
Copy link
Copy Markdown
Contributor

Lol, one of my guys is doing it now anyway cause hes wanting to add in a variable for the user :)

@silversword411
Copy link
Copy Markdown
Contributor

ChatGPT....

@bbrendon
Copy link
Copy Markdown
Contributor Author

I just ran this on a VM without issue.

@dinger1986
Copy link
Copy Markdown
Contributor

Tbf nothing fundamental has changed with it so will work fine, same as the old one.

I need to chase up the powershell script

@bbrendon
Copy link
Copy Markdown
Contributor Author

rdp won't with if you don't start it. seems pretty important.

@bbrendon
Copy link
Copy Markdown
Contributor Author

Also, it won't work if its disabled as well.

@dinger1986
Copy link
Copy Markdown
Contributor

Hmmm, weird thing is that I wrote that script pre covid and never had to start it or change it from disabled. It's always just worked.

Not disagreeing at all, yours is neater.

@silversword411 you can merge.

I'll get a powershell script submitted soon

@bbrendon
Copy link
Copy Markdown
Contributor Author

Did you test on Win11? It didn't work for me which is why I submitted a PR.

@silversword411 silversword411 merged commit 4a6f960 into amidaware:main Apr 25, 2023
@silversword411
Copy link
Copy Markdown
Contributor

Would really like a AIO rdp enable/disable script as an alternative...and fix TRMM install rdp option which doesn't work either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants