Skip to content

Delete scripts/Win_RustDesk_GetID.ps1#179

Closed
dinger1986 wants to merge 2 commits intoamidaware:mainfrom
dinger1986:main
Closed

Delete scripts/Win_RustDesk_GetID.ps1#179
dinger1986 wants to merge 2 commits intoamidaware:mainfrom
dinger1986:main

Conversation

@dinger1986
Copy link
Copy Markdown
Contributor

No description provided.

@dinger1986
Copy link
Copy Markdown
Contributor Author

script doesnt work, best to work from docs and keep everything out of scripts for RustDesk

@silversword411
Copy link
Copy Markdown
Contributor

silversword411 commented Aug 30, 2023

I've been debating how to handle the existing rustdesk stuff.

Rustdesk definitely in flux atm. Probably best to pull, if there are installs in the field this is going to mess with status.

We still have the outstanding bug about deleting community scripts causing problems in the field. Need to refresh memory and check before accepting this.

@dinger1986
Copy link
Copy Markdown
Contributor Author

I think its best to keep it in the docs, one place to update, its reliant on users having a custom field setup as well.

The script doesnt work with 1.2.2 so pointless having it

@NiceGuyIT
Copy link
Copy Markdown
Contributor

We still have the outstanding big about deleting community scripts causing problems in the field. Need to refresh memory and check before accepting this.

The issue is if a community script is deleted, the corresponding check (and task?) will be silently deleted when people update. It's better to update the script with a message and exit with an error. That will signal to the observant user that the script is no longer working. If people don't monitor for errors from scripts, that's on them.

@dinger1986
Copy link
Copy Markdown
Contributor Author

ok yes that makes sense, its just to try and not have to maintain scripts in 2 places and then rustdesk update something and people say well trmm isnt up to date

@dinger1986 dinger1986 closed this Aug 30, 2023
@silversword411
Copy link
Copy Markdown
Contributor

This was the one: amidaware/tacticalrmm#1486

Should probably have some kind of obvious naming convention and keyword(s).

@dinger1986
Copy link
Copy Markdown
Contributor Author

So we should rename the script to !!!Broken - Read Docs or something similar?

1 similar comment
@dinger1986
Copy link
Copy Markdown
Contributor Author

So we should rename the script to !!!Broken - Read Docs or something similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants