Basic memory usage check for Linux#66
Conversation
|
Hi Benjamin, Are these scripts confirmed working? If so please PR to scripts folder and update the json 😃. https://docs.tacticalrmm.com/contributing_community_scripts/ Thanks! |
Yes, I have these checks in use on all my Linux servers. |
|
Hey, @dinger1986 @silversword411, would either of you mind reviewing this when you get a chance? Thanks! |
|
You added bash to the tests, need @wh1te909 to look at and approve this one. |
|
|
||
| def test_community_script_json_file(): | ||
| valid_shells = ["powershell", "python", "cmd"] | ||
| valid_shells = ["powershell", "python", "cmd", "bash"] |
There was a problem hiding this comment.
so this might be a bit confusing lol but for linux the shell is determined by the shebang and the top of the script, so can be any shell really not just bash. so instead of bash it needs to be shell as in shell scripts. see https://github.com/amidaware/tacticalrmm/blob/5e37728f66ff712a20b7078499ab8214d6d62b01/api/tacticalrmm/tacticalrmm/constants.py#L120 for list of valid shells
There was a problem hiding this comment.
Ah sorry about that, I was basing it off of what was listed here:
https://docs.tacticalrmm.com/contributing_community_scripts/#json-field-names
I just pushed a commit to update it to shell instead of bash
4 participants
As the tin says.
Configurable by passing a value to the check