fix: CategoryMenu is_active logic#920
Merged
aminalaee merged 1 commit intoaminalaee:mainfrom May 26, 2025
Merged
Conversation
The `CategoryMenu.is_active` function was incorrectly returning `True` if any of the children were visible.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous PR (#698) introduced a bug in the
CategoryMenu.is_activefunction, causing it to returnTrueif any child elements were visible. This led to misleading template errors, making all categories appear active since they all contain visible children.This update includes:
CategoryMenu._menumacros to ensure categories are displayed not only if they are active but also if they are visible and accessible to the current user.