Refactor: Improve Desktop WebView loading and stability #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several improvements to the desktop WebView implementation:
- **Increased delay for file loading:** The delay before loading local HTML files (both from assets and Compose resources) has been increased from 200ms to 500ms. This provides more time for file extraction and setup, potentially improving reliability.
- **Error handling for HTML loading:** Added `e.printStackTrace()` in the `catch` block of `DesktopWebView.loadHtml` for better debugging of HTML loading errors.
- **Unified content loading:** Refactored `WebView.kt` to use a common `wv.loadContent(content)` call within the `LaunchedEffect` for all content types, simplifying the logic.
- **Refined Desktop WebView initialization:**
- The `KCEFBrowser` instance is now recreated if `state.content` changes, ensuring the browser is correctly initialized for different content types (e.g., when switching from URL to File).
- `WebViewFactoryParam` for `WebContent.File` now passes `param.requestContext` to `createBrowser`.
- `state.webView` and `webViewJsBridge?.webView` are now set within a `LaunchedEffect` dependent on `desktopWebView` to ensure they are assigned after the `DesktopWebView` instance is fully created.
- **Removed verbose logging:** Removed some KLogger debug statements related to navigation events and disposal.
- **Standardized File import:** Changed `java.io.File` to `File` for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several improvements to the desktop WebView implementation:
e.printStackTrace()in thecatchblock ofDesktopWebView.loadHtmlfor better debugging of HTML loading errors.WebView.ktto use a commonwv.loadContent(content)call within theLaunchedEffectfor all content types, simplifying the logic.KCEFBrowserinstance is now recreated ifstate.contentchanges, ensuring the browser is correctly initialized for different content types (e.g., when switching from URL to File).WebViewFactoryParamforWebContent.Filenow passesparam.requestContexttocreateBrowser.state.webViewandwebViewJsBridge?.webVieware now set within aLaunchedEffectdependent ondesktopWebViewto ensure they are assigned after theDesktopWebViewinstance is fully created.java.io.FiletoFilefor consistency.