Sync SDK with Etsy API spec — add buyer_country, currency params#21
Merged
amitray007 merged 2 commits intomasterfrom Apr 6, 2026
Merged
Sync SDK with Etsy API spec — add buyer_country, currency params#21amitray007 merged 2 commits intomasterfrom
amitray007 merged 2 commits intomasterfrom
Conversation
Sync SDK with latest Etsy OAS spec changes: - Add buyer_country and currency optional query params to find_all_listings_active - Add buyer_country and currency optional query params to get_listings_by_listing_ids - Update specs/baseline.json to latest spec (includes new ListingBuyerPrice schema, converted_price field, BuyerPrice includes option) Closes #20 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add tests for buyer_country and currency on find_all_listings_active - Add tests for buyer_country and currency on get_listings_by_listing_ids - Add BUYER_PRICE enum value to Includes to match updated spec Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Test Coverage ReportOverall: 93% (1534/1644 statements covered) Coverage by file
Updated by PR Tests |
There was a problem hiding this comment.
Pull request overview
Updates the Python SDK to align with the latest Etsy OpenAPI spec by adding newly introduced query parameters for listing retrieval and extending the listings “includes” options.
Changes:
- Added optional
buyer_countryandcurrencyquery params tofind_all_listings_activeandget_listings_by_listing_ids. - Added
BUYER_PRICEto theIncludesenum to match the new spec include option. - Updated
specs/baseline.jsonto the latest Etsy OAS baseline (including buyer price / converted price schema updates).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
etsy_python/v3/resources/Listing.py |
Adds buyer_country/currency passthrough in query params for the two affected endpoints. |
etsy_python/v3/enums/Listing.py |
Extends Includes with BUYER_PRICE = "BuyerPrice" per spec. |
tests/test_listing_resource.py |
Adds tests verifying passthrough and default None behavior for the new query params. |
specs/baseline.json |
Syncs stored OpenAPI baseline to reflect the latest Etsy spec changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #20 — syncs the SDK with the latest Etsy OAS spec changes.
buyer_countryandcurrencyoptional query params tofind_all_listings_activeandget_listings_by_listing_idsBUYER_PRICEvalue to theIncludesenum (new spec includes option)specs/baseline.jsonto latest Etsy OAS spec (captures newListingBuyerPriceschema,converted_price/buyer_priceresponse fields)Informational (no code changes needed):
createDraftListing/updateListing— already handled with deprecation warningsState.REMOVEDnot in spec — already documentedTest plan
pytest -v)buyer_country/currencyparam passthrough and default behaviorOptional[str])BuyerPriceenum value matches spec casing🤖 Generated with Claude Code