Merged
Conversation
CI lint-test failed on the 0.3.0 release commit due to three unused imports left over from iteration: - src/approvals.js: resolveSigningKey - test/approvals.test.js: writeFileSync, mkdirSync Removing them. No functional change. The v0.3.0 tag on GitHub and the @amittell/agentcli@0.3.0 package on npm were published from a commit that has this fix applied, so this is a main-catch-up commit only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/approvals.js: drops unusedresolveSigningKeyimport.test/approvals.test.js: drops unusedwriteFileSyncandmkdirSyncimports.No functional change. This is a main-catch-up commit: the
v0.3.0tag on GitHub and@amittell/agentcli@0.3.0on npm were published from a commit that already has this fix applied (the original release commit was amended during recovery, but force-push tomainis protected, somainlanded at the pre-fix commit).Test plan
npm run lintclean locallynpm testgreen locally (659/659)lint-testpasses on this PR