Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 12, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nock 13.3.3 -> 13.3.4 age adoption passing confidence

Release Notes

nock/nock (nock)

v13.3.4

Compare Source

Bug Fixes
  • typescript: support nock(new URL('https://example.test/')) (#​2526) (6987327)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Oct 12, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: express-prometheus-middleware@1.2.0
npm ERR! Found: prom-client@15.0.0
npm ERR! node_modules/prom-client
npm ERR!   prom-client@"^15.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer prom-client@">= 10.x <= 13.x" from express-prometheus-middleware@1.2.0
npm ERR! node_modules/express-prometheus-middleware
npm ERR!   express-prometheus-middleware@"^1.2.0" from the root project
npm ERR!   express-prometheus-middleware@"^1.2.0" from @ammar-ahmed/automation-app-bot@1.2.8
npm ERR!   node_modules/@ammar-ahmed/automation-app-bot
npm ERR!     @ammar-ahmed/automation-app-bot@"^1.2.7" from the root project
npm ERR!     1 more (@ammar-ahmed/automation-app-bot)
npm ERR! 
npm ERR! Conflicting peer dependency: prom-client@13.2.0
npm ERR! node_modules/prom-client
npm ERR!   peer prom-client@">= 10.x <= 13.x" from express-prometheus-middleware@1.2.0
npm ERR!   node_modules/express-prometheus-middleware
npm ERR!     express-prometheus-middleware@"^1.2.0" from the root project
npm ERR!     express-prometheus-middleware@"^1.2.0" from @ammar-ahmed/automation-app-bot@1.2.8
npm ERR!     node_modules/@ammar-ahmed/automation-app-bot
npm ERR!       @ammar-ahmed/automation-app-bot@"^1.2.7" from the root project
npm ERR!       1 more (@ammar-ahmed/automation-app-bot)
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/worker/ea9dc9/bf5f31/cache/others/npm/_logs/2023-10-14T00_14_06_808Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/worker/ea9dc9/bf5f31/cache/others/npm/_logs/2023-10-14T00_14_06_808Z-debug-0.log

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e6550d
Status: ✅  Deploy successful!
Preview URL: https://5059fc24.automation-app-bot.pages.dev
Branch Preview URL: https://renovate-nock-13-x.automation-app-bot.pages.dev

View logs

@restack-app
Copy link

restack-app bot commented Oct 12, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@commit-lint
Copy link

commit-lint bot commented Oct 12, 2023

Chore

  • deps: update dependency nock to v13.3.4 (0e6550d)

Contributors

renovate[bot]

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@sweep-ai-deprecated
Copy link

sweep-ai-deprecated bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Oct 12, 2023

👋 Hi there!

The most important thing to improve in the code-diff is to update the "nock" package version from "13.3.3" to "13.3.4" for potential bug fixes or security updates. Additionally, it would be beneficial to review and update other dependencies if there are newer versions available with important improvements or fixes. Lastly, consider removing unused dependencies to optimize the package.json file.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

@instapr
Copy link

instapr bot commented Oct 12, 2023

Code Review Feedback:

  • The PR looks good overall.
  • I have reviewed the changes and the release notes for the updated dependency nock.
  • The only change in this PR is updating the nock dependency from version 13.3.3 to 13.3.4 in the package.json file.
  • The release notes for nock v13.3.4 indicate that it includes a bug fix for supporting nock(new URL('https://example.test/')) in TypeScript. This seems like a necessary and beneficial update.
  • The PR can be manually merged once you are satisfied.

Please let me know if you have any questions or need further assistance.

Thank you!

@pr-explainer-bot
Copy link

Pull Request Report

Greetings!

Hey there! I'm your friendly neighborhood bot, here to provide you with a report on the changes made in the pull request. Let's dive right in!

Changes

  1. Updated dependency nock from version 13.3.3 to 13.3.4. 🔄

Suggestions

No suggestions for improvement have been provided.

Bugs

No potential bugs have been identified.

Improvements

No specific areas for improvement have been highlighted.

Rating

On a scale of 0 to 10, here's how the code rates based on the following criteria:

  • Readability:
  • Performance:
  • Security:

Please provide a brief explanation for each criterion.

That's it for the report! If you have any further questions or need assistance, feel free to reach out. Happy coding!

@renovate renovate bot force-pushed the renovate/nock-13.x branch 2 times, most recently from 87067eb to 8e32e51 Compare October 13, 2023 23:50
@renovate renovate bot force-pushed the renovate/nock-13.x branch from 8e32e51 to 0e6550d Compare October 14, 2023 00:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ammar-ahmed-butt ammar-ahmed-butt merged commit c7ce2ee into master Oct 15, 2023
@mergeable
Copy link

mergeable bot commented Oct 15, 2023

⚠️

Please add Jira ticket id i.e. "JIRA-ID"

Check Fail Adhere to the branch naming convention described here

@renovate renovate bot deleted the renovate/nock-13.x branch October 15, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants