Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 25, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prom-client ^13.0.0 -> ^15.0.0 age adoption passing confidence

Release Notes

siimon/prom-client (prom-client)

v15.0.0

Compare Source

Breaking
  • drop support for Node.js versions 10, 12, 14, 17 and 19
Changed
  • Refactor histogram internals and provide a fast path for rendering metrics to
    Prometheus strings when there are many labels shared across different values.
  • Disable custom content encoding for pushgateway delete requests in order to
    avoid failures from the server when using Content-Encoding: gzip header.
  • Refactor escapeString helper in lib/registry.js to improve performance and
    avoid an unnecessarily complex regex.
  • Cleanup code and refactor to be more efficient
  • Correct TS types for working with OpenMetrics
  • Updated Typescript and Readme docs for setToCurrentTime() to reflect units as seconds.
  • Do not ignore error if request to pushgateway fails
  • Make sure to reject the request to pushgateway if it times out
Added
  • Support for OpenMetrics and Exemplars

v14.2.0

Compare Source

Changed
  • Refactor getMetricAsPrometheusString method in the Registry class to use Array.prototype.join
    instead of loop of string concatenations.
  • Also use Array.prototype.map, and object spread instead of an explicit for loop
  • changed: updated the sample output in example/default-metrics.js
  • summary metrics now has a pruneAgedBuckets config parameter
    to remove entries without any new values in the last maxAgeSeconds.
    Default is false (old behavior)
Added
  • Add get method to type definitions of metric classes

v14.1.1

Compare Source

Changed
  • Increase compatibility with external build system such as rollup by making perf_hooks optional in gc.js

v14.1.0

Compare Source

Changed
  • types: converted all the generic Metric types to be optional

  • The done() functions returned by gauge.startTimer() and
    summary.startTimer() now return the timed duration. Histograms already had
    this behavior.

  • types: fixed type for registry.getMetricsAsArray()

  • Improve performance of gague.inc() and gauge.dec() by calling hashObject() once.

Added
  • The processResources metric was added, which keeps a track of all sorts of
    active resources. It consists of the following gauges:

    • nodejs_active_resources - Number of active resources that are currently
      keeping the event loop alive, grouped by async resource type.
    • nodejs_active_resources_total - Total number of active resources.
      It is supposed to provide the combined result of the processHandles and
      processRequests metrics along with information about any other types of
      async resources that these metrics do not keep a track of (like timers).
  • Support gzipped pushgateway requests

v14.0.1

Compare Source

Changed
  • changed: typedef for pushgateway to reflect js implementation.

v14.0.0

Compare Source

Breaking
  • changed: linearBuckets does not propagate rounding errors anymore.

    Fewer bucket bounds will be affected by rounding errors. Histogram bucket
    labels may change. 6f1f3b2

  • changed: The push gateway methods pushAdd(), push() and delete() now
    return Promises instead of accepting a callback:

    // Old:
    gateway.pushAdd({ jobName: 'test' }, (err, resp, body) => {});
    // New:
    gateway
      .pushAdd({ jobName: 'test' })
      .then(({ resp, body }) => {})
      .catch(err => {});
    // or
    const { resp, body } = await gateway.pushAdd({ jobName: 'test' });

    f177b1f

  • changed: The default nodejs_eventloop_lag_* metrics are now reset every time
    they are observed. This prevents these metrics from "stabilizing" over a long
    period of time and becoming insensitive to small changes. For more info, see
    #​370. 0f444cd

Changed
  • Add missing await/thens to examples. 074f339
  • Add missing type declaration for client.contentType. 3b66641
  • Modernize some label processing code. c9bf1d8

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Oct 25, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: express-prometheus-middleware@1.2.0
npm ERR! Found: prom-client@15.0.0
npm ERR! node_modules/prom-client
npm ERR!   prom-client@"^15.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer prom-client@">= 10.x <= 13.x" from express-prometheus-middleware@1.2.0
npm ERR! node_modules/express-prometheus-middleware
npm ERR!   express-prometheus-middleware@"^1.2.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: prom-client@13.2.0
npm ERR! node_modules/prom-client
npm ERR!   peer prom-client@">= 10.x <= 13.x" from express-prometheus-middleware@1.2.0
npm ERR!   node_modules/express-prometheus-middleware
npm ERR!     express-prometheus-middleware@"^1.2.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/worker/8ae7ac/6d1ba2/cache/others/npm/_logs/2023-10-25T01_43_55_569Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/worker/8ae7ac/6d1ba2/cache/others/npm/_logs/2023-10-25T01_43_55_569Z-debug-0.log

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3894651
Status: ✅  Deploy successful!
Preview URL: https://1050f9fe.automation-app-bot.pages.dev
Branch Preview URL: https://renovate-prom-client-15-x.automation-app-bot.pages.dev

View logs

@restack-app
Copy link

restack-app bot commented Oct 25, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@commit-lint
Copy link

commit-lint bot commented Oct 25, 2023

Bug Fixes

  • deps: update dependency prom-client to v15 (3894651)

Contributors

renovate[bot]

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@coderabbitai
Copy link

coderabbitai bot commented Oct 25, 2023

Important

Review Skipped

Reviews are disabled for bot users.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@pr-code-reviewer
Copy link

👋 Hi there!

The most important things to improve in the code-diff are:

  1. Update the version of "prom-client" from "^13.0.0" to "^15.0.0" to ensure compatibility with the latest features and bug fixes.
  2. Review and potentially update other dependencies to their latest compatible versions for better performance, security, and stability.
  3. Check if any outdated or unnecessary devDependencies can be removed to streamline the development process and reduce package size.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

@instapr
Copy link

instapr bot commented Oct 25, 2023

Code Review Comments:

  • The dependency prom-client has been updated from ^13.0.0 to ^15.0.0.
  • Please ensure that the tests pass with the updated version.
  • Verify if there are any breaking changes introduced by this update and make any necessary changes to your code.

Let me know if you have any questions or concerns.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pr-explainer-bot
Copy link

Pull Request Report

Hey there! 👋 Here's a report for the changes made in this pull request:

Changes

  1. Updated dependency prom-client to version 15.0.0. 🔄

Suggestions to Improve Code

No suggestions provided. 🤔

Bugs

No bugs found. 🐛

Improvements

No improvements suggested. 🚀

Refactoring for Better Readability

No code snippets provided for refactoring. 😕

Rating

Overall rating for the code: 7/10. Here's a brief explanation of the criteria:

  • Readability: The code is fairly readable and easy to understand. 👍
  • Performance: No specific performance issues found. 💨
  • Security: No security concerns identified. 🔒

That's it for the report! Let me know if you need any further assistance. 😄

@sweep-ai-deprecated
Copy link

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@ammar-ahmed-butt ammar-ahmed-butt merged commit cfcc5b2 into master Oct 25, 2023
@mergeable
Copy link

mergeable bot commented Oct 25, 2023

⚠️

Please add Jira ticket id i.e. "JIRA-ID"

Check Fail Adhere to the branch naming convention described here

@renovate renovate bot deleted the renovate/prom-client-15.x branch October 25, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants