Skip to content

feat: add Brave search engine to web_search provider#859

Merged
amnweb merged 1 commit intoamnweb:mainfrom
TheJobGG:feature/web-search-brave
Apr 18, 2026
Merged

feat: add Brave search engine to web_search provider#859
amnweb merged 1 commit intoamnweb:mainfrom
TheJobGG:feature/web-search-brave

Conversation

@TheJobGG
Copy link
Copy Markdown
Contributor

Adds support for Brave search in the web_search provider including description and an icon that matches the existing style.

Example of quick launch widget with Brave search.

yasb-brave-as-engine-option

@amnweb
Copy link
Copy Markdown
Owner

amnweb commented Apr 16, 2026

Please clean up the commit history. All of this can be under one commit.

@TheJobGG TheJobGG force-pushed the feature/web-search-brave branch from 00b79e8 to 9816636 Compare April 16, 2026 19:41
@TheJobGG
Copy link
Copy Markdown
Contributor Author

@amnweb Done

@amnweb
Copy link
Copy Markdown
Owner

amnweb commented Apr 16, 2026

Thanks, but you forgot to document this https://github.com/amnweb/yasb/wiki/(Widget)-Quick-Launch#web-search-provider

@TheJobGG
Copy link
Copy Markdown
Contributor Author

@amnweb I've added the brave option into the documentation. Would you like this squashed into a single commit or is it fine to keep it as a separate docs commit?

@amnweb
Copy link
Copy Markdown
Owner

amnweb commented Apr 16, 2026

Yeah, squash changes into a single commit.

Includes:
- Brave search engine integration
- Icon matching existing style
- Documentation update for web_search provider
@TheJobGG TheJobGG force-pushed the feature/web-search-brave branch from deba056 to 86110b1 Compare April 17, 2026 00:06
@TheJobGG
Copy link
Copy Markdown
Contributor Author

@amnweb Commits squashed

@amnweb amnweb merged commit fa8c772 into amnweb:main Apr 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants