Conversation
Use id() instead of the expensive unicode() that has the side effect of actually running the command if it is not already running, and blocking until the command has finished running.
Use id() for equality between running commands
…hen resolving commands. Refs #604
Without this fix, this test case would raise: TypeError: descriptor '__dict__' for 'Command' objects doesn't apply to a 'Command' object
This fixes the example I provided at #556 (comment) by making fd/file_chunk_consumer respect decode_errors just like the other consumers.
Also added some latin-1 encoded bytes to make it always invalid for sys.stdout too.
Feature/repeating kwargs
WIP: Release/v2.0.0
amoffat
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.