[ENG-2552] feat: confirm if read schedules should be stopped when installations exist for an integration#243
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds confirmation prompts when deploying integrations that have removed read objects from their YAML configuration, warning users that active read schedules for those objects will be stopped.
Key changes:
- Added functionality to detect removed read objects by comparing old and new integration manifests
- Implemented user confirmation prompts that display affected installations
- Enhanced the deploy command to check for removed objects before proceeding with deployment
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| files/zip.go | Added ReadManifestFile function to extract manifest content from zip sources |
| files/manifest.go | Added GetRemovedReadObjects function to compare old and new integrations for removed read objects |
| files/manifest_test.go | Added comprehensive test coverage for the GetRemovedReadObjects function |
| cmd/deploy.go | Enhanced deploy command with confirmation logic and user prompting for removed read objects |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
laurenzlong
requested changes
Oct 1, 2025
Contributor
There was a problem hiding this comment.
Can you please modify the output to look like the following? (note the additional empty lines)
You are removing the following read action object(s) from integration 'readSalesforce': contacts, leads.
Any active scheduled reads for these objects will be stopped.
This integration has 12 installation(s).
- Acme Corp (acme-corp)
- FooBar Inc (foo-bar)
- and 10 more
Do you still want to deploy a new revision of this integration? [y/N]
e8e0557 to
1d66973
Compare
laurenzlong
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a builder removes read objects from an integration YAML, we now show a confirmation prompt before deploying. This gives them a heads-up that any active read schedules for those objects will be stopped.
What it looks like:
The above prompt will repeat for each integration that they are removing read objects for.
Changes
Testing