feat: Allow the stage to be overridden at runtime#99
Merged
Conversation
eberle1080
requested review from
a team,
RajatPawar and
jlimatampersand
and removed request for
a team and
RajatPawar
jlimatampersand
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now most runtime vars can be overridden (api endpoint, clerk login endpoint, etc). This lets us use prod binaries against dev and staging, which is useful.
However stage is hard-coded. This makes the program slightly clunky because the local paths it uses to store credentials are mis-matched. This can be worked around, but it's just kind of confusing.
This allows the caller to override the effective stage by setting
AMP_STAGE_OVERRIDE, which will eliminate the mismatched credentials confusion.