[ENG-3857] Refactor: Providerinfo subscribe support config#352
Merged
jlimatampersand merged 3 commits intomainfrom Apr 24, 2026
Merged
[ENG-3857] Refactor: Providerinfo subscribe support config#352jlimatampersand merged 3 commits intomainfrom
jlimatampersand merged 3 commits intomainfrom
Conversation
4f03b42 to
b03e301
Compare
laurenzlong
approved these changes
Apr 24, 2026
Comment on lines
+647
to
+668
| SubscribeRequirements: | ||
| title: Subscribe Action Requirements | ||
| type: object | ||
| description: Declares which auxiliary steps a provider requires to support subscriptions, beyond the per-object subscribe call itself. | ||
| properties: | ||
| registration: | ||
| type: boolean | ||
| description: >- | ||
| Whether the provider requires a one-time registration step that is shared across all subscribed objects. | ||
| The subscribe method is object-scoped, so if a separate API call is needed beyond per-object configuration | ||
| (e.g., registering a single webhook/endpoint that all object subscriptions hang off of), registration is required. | ||
| maintenance: | ||
| type: boolean | ||
| description: >- | ||
| Whether the subscription requires periodic maintenance. Some providers expire subscriptions/watches after | ||
| a fixed TTL, so the subscription must be renewed on a schedule to remain active. | ||
| postProcess: | ||
| type: boolean | ||
| description: >- | ||
| Whether subscribing requires a third-party setup step that the connector instance itself cannot perform. | ||
| Examples: Salesforce requires AWS EventBridge configuration; Gmail requires a Google Pub/Sub topic to be | ||
| configured. Any configuration that must happen outside the connector falls into post-process. |
There was a problem hiding this comment.
Schema name mismatch: The schema is defined as SubscribeRequirements but line 586 references SubscribeSupportConfig. This will cause schema resolution to fail.
# Change from:
SubscribeRequirements:
title: Subscribe Action Requirements
# To:
SubscribeSupportConfig:
title: Subscribe Support ConfigThe schema name must match the $ref target at line 586, or the reference must be updated to point to SubscribeRequirements. Based on the generated JSON files using SubscribeSupportConfig, the schema should be renamed to SubscribeSupportConfig.
Suggested change
| SubscribeRequirements: | |
| title: Subscribe Action Requirements | |
| type: object | |
| description: Declares which auxiliary steps a provider requires to support subscriptions, beyond the per-object subscribe call itself. | |
| properties: | |
| registration: | |
| type: boolean | |
| description: >- | |
| Whether the provider requires a one-time registration step that is shared across all subscribed objects. | |
| The subscribe method is object-scoped, so if a separate API call is needed beyond per-object configuration | |
| (e.g., registering a single webhook/endpoint that all object subscriptions hang off of), registration is required. | |
| maintenance: | |
| type: boolean | |
| description: >- | |
| Whether the subscription requires periodic maintenance. Some providers expire subscriptions/watches after | |
| a fixed TTL, so the subscription must be renewed on a schedule to remain active. | |
| postProcess: | |
| type: boolean | |
| description: >- | |
| Whether subscribing requires a third-party setup step that the connector instance itself cannot perform. | |
| Examples: Salesforce requires AWS EventBridge configuration; Gmail requires a Google Pub/Sub topic to be | |
| configured. Any configuration that must happen outside the connector falls into post-process. | |
| SubscribeSupportConfig: | |
| title: Subscribe Support Config | |
| type: object | |
| description: Declares which auxiliary steps a provider requires to support subscriptions, beyond the per-object subscribe call itself. | |
| properties: | |
| registration: | |
| type: boolean | |
| description: >- | |
| Whether the provider requires a one-time registration step that is shared across all subscribed objects. | |
| The subscribe method is object-scoped, so if a separate API call is needed beyond per-object configuration | |
| (e.g., registering a single webhook/endpoint that all object subscriptions hang off of), registration is required. | |
| maintenance: | |
| type: boolean | |
| description: >- | |
| Whether the subscription requires periodic maintenance. Some providers expire subscriptions/watches after | |
| a fixed TTL, so the subscription must be renewed on a schedule to remain active. | |
| postProcess: | |
| type: boolean | |
| description: >- | |
| Whether subscribing requires a third-party setup step that the connector instance itself cannot perform. | |
| Examples: Salesforce requires AWS EventBridge configuration; Gmail requires a Google Pub/Sub topic to be | |
| configured. Any configuration that must happen outside the connector falls into post-process. | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
7ef91a8 to
664a48e
Compare
4 tasks
dionlow
pushed a commit
to amp-labs/react
that referenced
this pull request
Apr 30, 2026
Backend (amp-labs/server#3839) and OpenAPI spec (amp-labs/openapi#354) now accept project name in addition to UUID on /oauth-connect. Regenerate the SDK and pass projectIdOrName straight from AmpersandProvider context, removing the unnecessary useProjectQuery() round-trip in the OAuth flow. The regenerated SDK also picks up unrelated providerInfo subscribe changes from amp-labs/openapi#352. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dionlow
added a commit
to amp-labs/react
that referenced
this pull request
Apr 30, 2026
Backend (amp-labs/server#3839) and OpenAPI spec (amp-labs/openapi#354) now accept project name in addition to UUID on /oauth-connect. Regenerate the SDK and pass projectIdOrName straight from AmpersandProvider context, removing the unnecessary useProjectQuery() round-trip in the OAuth flow. The regenerated SDK also picks up unrelated providerInfo subscribe changes from amp-labs/openapi#352. Co-authored-by: Dion Low <dion@withampersand.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These registration, maintenance, postprocess configs were in server repo, but we should move to provider info.