fix: hide variant prop from public InstallIntegrationProps type#1566
Merged
fix: hide variant prop from public InstallIntegrationProps type#1566
Conversation
Split InstallIntegrationProps into a public type (without variant) and an internal InstallIntegrationInternalProps (with variant?: "wizard"). Only the public type is exported, so variant no longer appears in the generated .d.ts declarations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dionlow
requested review from
a team and
jlimatampersand
and removed request for
a team
jlimatampersand
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hidden prop didn't stop the IDE from detecting. Updated types to have an internal only type.
InstallIntegrationPropsinto a public type (exported, withoutvariant) and an internalInstallIntegrationInternalProps(not exported, extends public withvariant?: "wizard")InstallIntegrationcomponent signature usesInstallIntegrationProps, sovariantno longer appears in generated.d.tsdeclarationsInstallIntegrationPropstype from the Configure barrel for consumer useTest plan
yarn buildsucceedsvariantdoes not appear inbuild/*.d.tsInstallIntegrationPropsis exported inbuild/*.d.tsvariant="wizard"still works at runtime when passed internallyts throws error
add ts exception when using