[ENG-3881] feat(ConnectProvider): make Salesforce subdomain optional#1602
Merged
[ENG-3881] feat(ConnectProvider): make Salesforce subdomain optional#1602
Conversation
dionlow
changed the title
Contributor
|
Change copy to "Advanced: sign in with custom subdomain" |
Contributor
Author
|
Copy Suggestion: "Use My Domain (advanced)" |
Default Salesforce OAuth to login.salesforce.com (no subdomain prompt). End users can still expand a "Sign in with a custom domain" disclosure to enter a subdomain when their org has disabled login.salesforce.com. Also consolidates ad-hoc Salesforce checks (startsWith / ===) into a shared isSalesforceProvider() helper, fixing a latent salesforceSandbox mislabel in AuthenticationSection. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WorkspaceEntryContent no longer receives Salesforce providers (OauthFlow2 routes them to SalesforceLandingContent). Remove the now-unreachable package-install-banner branch, useProviderAppByProvider call, isPending gate, Stepper inside the form, and the unused `provider` prop. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…nced)" Aligns with Salesforce's official "My Domain" feature name (Setup → Company Settings → My Domain) so admins recognize it instantly, and the "(advanced)" parenthetical discourages casual clicks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dionlow
force-pushed
the
feat/salesforce-optional-subdomain
branch
from
756b465 to
e63d165
Compare
jlimatampersand
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Salesforce workspace is optional in the OAuth endpoint. This PR updates the UX so that ConnectProvider also allows this interaction.
ConnectProvidernow defaults tologin.salesforce.com— no subdomain prompt by default. TheproviderWorkspaceReffield is already optional in the OAuth Connect endpoint.<details>disclosure on the OAuth landing, for orgs whose admins have disabledlogin.salesforce.com.Slack context: https://ampersand-company.slack.com/archives/C082KPRN4R4/p1777064901047689
note: This PR does not include testing for UpdateConnection.
Test plan
login.salesforce.comacme→ popup opens againsthttps://acme.my.salesforce.com/...; verifyproviderWorkspaceRef=acmein the/oauth-connectrequestproviderWorkspaceRefsent)AuthenticationSectionWorkspaceEntryContentunchanged