Implement improved pii taggging #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create comprehensive TDD plan for bulk-tag-pii interactive command - Implement basic command handler with parameter validation - Add test suite with parameter validation coverage - Support active config fallback for catalog/schema/warehouse - Include helpful error messages for missing resources - Follow established patterns from setup_stitch implementation Week 1 Foundation: Parameter validation and basic structure complete
- Add CommandDefinition for bulk-tag-pii with proper parameters - Register command in commands/__init__.py - Support interactive input with /bulk-tag-pii TUI alias - Set agent display to "full" for comprehensive output - Command now available to both users and agents Registry integration complete for Week 1 foundation
- Implement minimal PII detection logic using table name heuristics - Add progress reporting for agent integration - Support both "PII found" and "No PII found" scenarios - Direct command tests now passing for success, no-PII, and partial failure cases - Progress callback integration for agent compatibility Week 1 Foundation Complete: ✅ Parameter validation with helpful errors ✅ Direct command execution (auto_confirm=True) ✅ Command registry integration ✅ Agent progress reporting ✅ Test coverage for core scenarios Ready for Week 2: Core functionality with real scan-pii integration
wip wip black fix change columns agent controls update bulk tag name
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new bulk PII tagging command and updates existing PII tagging interfaces to be more explicit.
- Adds a
bulk_tag_piicommand to the CLI, help menu, and system prompts - Renames the
/tag-piialias to/tag-pii-columnsfor clarity - Updates agent/system prompts and internal command registry to include the new bulk tagging flow
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| chuck_data/ui/help_formatter.py | Added bulk-tag-pii under the PII & Data Management menu |
| chuck_data/commands/tag_pii.py | Changed CLI alias from /tag-pii to /tag-pii-columns |
| chuck_data/commands/init.py | Registered bulk_tag_pii_definition in the command list |
| chuck_data/agent/prompts/default_system_prompt.py | Inserted a “PII TAGGING” section and renumbered the list |
| CLAUDE.md | Added a guide on writing behavioral tests with agent coverage |
Comments suppressed due to low confidence (3)
chuck_data/commands/tag_pii.py:211
- Changing the existing
/tag-piialias is a breaking change. Consider adding/tag-pii-columnsalongside the old alias (or deprecating/tag-pii) to avoid disrupting existing scripts.
tui_aliases=["/tag-pii-columns"],
chuck_data/agent/prompts/default_system_prompt.py:28
- The numbering and bullet-prefix style here differs from the rest of the list. Align it with the existing
-<number>.pattern or switch to a Markdown ordered list (1.,2., ...) for maintainability.
3. PII TAGGING: To help with bulk PII tagging across a schema:
chuck_data/commands/init.py:17
- You’ve added a new
bulk_tag_piicommand; consider adding or updating behavioral and unit tests to cover both the direct and agent-invoked paths for this feature.
from .bulk_tag_pii import DEFINITION as bulk_tag_pii_definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement improved pii tagging