Need fix after amphp/sql update #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Sep 15, 2018
src/PgSqlResultSet.php
Outdated
| * @return int Number of fields in each row. | ||
| */ | ||
| public function numFields(): int | ||
| public function getNumFields(): int |
Member
There was a problem hiding this comment.
Should probably be getFieldCount()?
src/PgSqlResultSet.php
Outdated
| * | ||
| * @throws \Error If the field number does not exist in the result. | ||
| */ | ||
| public function fieldName(int $fieldNum): string |
kelunik
reviewed
Sep 15, 2018
src/ResultSet.php
Outdated
| * @return int | ||
| */ | ||
| public function numFields(): int; | ||
| public function getNumFields(): int; |
Member
There was a problem hiding this comment.
Can this be added to Amp\Sql\ResultSet or does MySQL not provide this information upfront?
Contributor
Author
There was a problem hiding this comment.
Amp\Mysql has this: public function getFields(): Promise
But it's written with Amp\Socket, so we can probably refactor it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #15