Global linting. Snippet testing and automation #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
We should add $(README.md) to the release target dependencies
Member
|
LGTM! |
Also, cleanup a few style and misc issues.
allanca
added a commit
that referenced
this pull request
Mar 11, 2015
Global linting. Snippet testing and automation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a linter to the build step and fixed the existing warnings. Should help prevent bugs in the future.
Given the regression in the snippet last week, I added some automation and testing around the snippet. Now, make minifies the snippet file and updates the README automatically. There are also some simple tests to prove that the snippet runs and proxies functions.