Property validation #180
Merged
Property validation #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blazzy
commented
Mar 28, 2019
blazzy
commented
- Stop warning when null property values are instrumented
- Allow for objects nested within arrays
djih
approved these changes
Mar 28, 2019
Member
djih
left a comment
djih
left a comment
There was a problem hiding this comment.
Does this mean we officially support objects in arrays? Also is silencing null warning messages considered a breaking change? 🤔
Contributor
Author
They show up in the analytics UI now under user activity in a way they didn't before. It's hard to do any interesting useful analysis on them yet without some special object flattening feature that is being worked on.
Ugh. I'll poll the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.