Run queued functions after script is loaded and set to window #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
what's the browser compatibility of this function?
Member
Author
There was a problem hiding this comment.
Chrome and Firefox definitely support it. It's part of the HTML 4.01 standard, and seeing as how IE9 has HTML5, it should be okay: http://www.w3schools.com/tags/ev_onload.asp
Member
Author
There was a problem hiding this comment.
Ok confirmed IE9 support for onload via my own virtualbox running IE9
Member
|
LGTM |
djih
added a commit
that referenced
this pull request
Oct 1, 2015
Run queued functions after script is loaded and set to window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In index we transfer the proxy function queue into the real amplitude object, and then in the snippet added a script load callback that runs the queued functions from within the amplitude object. This guarantees that the real amplitude object is set in window.amplitude, allowing init callbacks to access amplitude properties and options.