Skip to content

build: add watch script #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

build: add watch script #339

merged 1 commit into from
Jan 4, 2021

Conversation

@jooohhn
Copy link
Contributor

@jooohhn jooohhn commented Jan 4, 2021

Summary

Improves dev UX by rebuilding when there is a file change

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@jooohhn jooohhn requested review from kelsonpw and kelvin-lu January 4, 2021 21:42
kelvin-lu
kelvin-lu approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@kelvin-lu kelvin-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

kelsonpw
kelsonpw approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@kelsonpw kelsonpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jooohhn jooohhn merged commit cc2c941 into master Jan 4, 2021
@jooohhn jooohhn deleted the build-watch branch January 4, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kelsonpw kelsonpw kelsonpw approved these changes

+1 more reviewer

@kelvin-lu kelvin-lu kelvin-lu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jooohhn @kelvin-lu @kelsonpw