Track referrer the right way #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we want referrer to be the referrer for the session, initial_referrer to be a set_once user property |
Member
Author
|
Initial referrer is saved via setOnce, and referrer is only set once per session. Since the server propagates user properties, we actually don't even need to send the referrer information with every event. We just send one initial identify call when initializing the SDK. Tested on local server. PTAL @curtisliu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using session storage to track initial referrer and persist for duration of user session. Note if sessionStorage not available (Chrome < 5, FF < 2, IE < 8, Safari < 4), then the initial_referrer and initial_referring_domains will default to empty string.