reload cookie when logging event #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user opens multiple tabs, then multiple SDK instances will be created, each maintaining its own session and event state. Each will write new values to the shared cookie, but never reloads from the cookie. As a result, the sessions and events from multiple windows can be not in-sync. An easy fix would be the always reload the cookie before logging an event, so the event will have the most update-to-date session and id. Incrementing the event id in one window should increment it for the others, etc. If one window is still maintaining the same session through activity, then no new sessions should be started in the other windows.