Skip to content

fix chrome mobile version parsing #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djih merged 2 commits into from
Oct 28, 2016
Merged

fix chrome mobile version parsing #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b93edac
fix chrome mobile version parsing
djih Oct 28, 2016
d7357b0
update changelog
djih Oct 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## Unreleased

* Updated our [UA-parser-js](https://github.com/amplitude/ua-parser-js) fork to properly parse the version number for Chrome Mobile browsers.

### 3.3.1 (October 26, 2016)

* Fix bug where tracking UTM params and referrer drops unsent events that have been saved to localStorage.
Expand Down
2 changes: 1 addition & 1 deletion amplitude.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4292,7 +4292,7 @@ module.exports = Revenue;
], [[NAME, /_/g, ' '], VERSION], [

/((?:android.+)crmo|crios)\/([\w\.]+)/i,
/android.+chrome\/([\w\.]+)\s+(?:mobile\s?safari)/i // Chrome for Android/iOS
/android.+(chrome)\/([\w\.]+)\s+(?:mobile\s?safari)/i // Chrome for Android/iOS
], [[NAME, 'Chrome Mobile'], VERSION], [

/(chrome|omniweb|arora|[tizenoka]{5}\s?browser)\/v?([\w\.]+)/i,
Expand Down
2 changes: 1 addition & 1 deletion amplitude.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion component.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"amplitude"
],
"dependencies": {
"amplitude/ua-parser-js": "fbdb1dc",
"amplitude/ua-parser-js": "ed538f1",
"amplitude/JavaScript-MD5": "2350ea9",
"component/object": "0.0.3",
"component/querystring": "1.3.0",
Expand Down
11 changes: 6 additions & 5 deletions test/ua-parser.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.