Conversation
Contributor
Author
|
bugbot run |
Contributor
Add
|
cursor Bot
pushed a commit
to amplitude/amplitude-docs
that referenced
this pull request
Jan 19, 2026
…king - Update formInteractions config to accept boolean | FormInteractionsOptions - Add documentation for shouldTrackSubmit callback to control form submit event tracking - Include examples for custom validation and form filtering use cases - Particularly useful for forms with novalidate attribute Relates to: amplitude/Amplitude-TypeScript#1500 Co-authored-by: xinyi.ye <xinyi.ye@amplitude.com>
Contributor
Author
|
bugbot run |
Contributor
Author
|
bugbot run |
…ng.ts Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com>
…ion' of github.com:amplitude/Amplitude-TypeScript into AMP-147416-form-submissions-fired-on-empty-form-submission
Contributor
Author
|
bugbot run |
Mercy811
added a commit
to amplitude/amplitude-docs
that referenced
this pull request
Jan 26, 2026
* docs: add shouldTrackSubmit callback option for form interaction tracking - Update formInteractions config to accept boolean | FormInteractionsOptions - Add documentation for shouldTrackSubmit callback to control form submit event tracking - Include examples for custom validation and form filtering use cases - Particularly useful for forms with novalidate attribute Relates to: amplitude/Amplitude-TypeScript#1500 Co-authored-by: xinyi.ye <xinyi.ye@amplitude.com> * docs: simplify form tracking examples to single use case Co-authored-by: xinyi.ye <xinyi.ye@amplitude.com> * Update minimum SDK version requirement for shouldTrackSubmit to 2.34.5 Co-authored-by: xinyi.ye <xinyi.ye@amplitude.com> * Update minimum SDK version for shouldTrackSubmit to 2.34.0 Co-authored-by: xinyi.ye <xinyi.ye@amplitude.com> * Add context about novalidate attribute and why shouldTrackSubmit is needed Co-authored-by: xinyi.ye <xinyi.ye@amplitude.com> * Update content/collections/browser_sdk/en/browser-sdk-2.md Co-authored-by: JeffScattini-amplitude <jeff.scattini@amplitude.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: JeffScattini-amplitude <jeff.scattini@amplitude.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
shouldTrackSubmitcallback option to form interaction config to control when[Amplitude] Form Submittedevents are tracked. This is particularly useful for forms with thenovalidateattribute where teams want full control over validation before tracking. Previously,[Amplitude] Form Submittedwas fired on every form submit event regardless of form validation state.Checklist
Note
Introduces configurable form submit gating.
FormInteractionsOptions.shouldTrackSubmittype inanalytics-coreand exports it; updatesBrowserConfig/AutocaptureOptionsto allowformInteractions: boolean | FormInteractionsOptions.getFormInteractionsConfigand integrates it in the form interaction plugin to conditionally track[Amplitude] Form Submitted(checksSubmitEvent, handles errors, keeps[Amplitude] Form Startedlogic unchanged).novalidateand demonstrates custom validation usage; minor experiment test adds version assertion.Written by Cursor Bugbot for commit b6cda67. Configure here.