fix: read GitHub App secrets from npm-release environment - #6
Merged
Conversation
AMPLITUDE_DEV_EXP_* are environment secrets (see Amplitude-TypeScript), not repo/org secrets. Attach release-please job to npm-release so the app token step can resolve them once infra copies the values in. Co-authored-by: Cursor <cursoragent@cursor.com>
daniel-graham-amplitude
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please still fails with
appId option is requiredbecauseAMPLITUDE_DEV_EXP_*are environment secrets onnpm-release, not org/repo secrets (confirmed: Amplitude-TypeScriptnpm-releasehas them; developer-clinpm-releasehas 0).This adds
environment: npm-releaseto the release-please job (publish already had it).Infra action still needed
Copy these environment secrets onto
amplitude/developer-cli→ Settings → Environments → npm-release (same values as Amplitude-TypeScript):AMPLITUDE_DEV_EXP_APP_IDAMPLITUDE_DEV_EXP_PRIVATE_KEYTrusted Publishing + npm OIDC is already configured; this unblocks the GitHub App token for release-please PRs.
After merge + secrets
main— app token step should showapp-id: ***npm-release→ npmbetaMade with Cursor