Skip to content

fix: Make AnalyticsConnector getInstance backwards compatible #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2024
Merged

fix: Make AnalyticsConnector getInstance backwards compatible #125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03492f6
fix: Make AnalyticsConnector getInstance backwards compatible
tyiuhc Sep 5, 2024
1fac060
set instanceName before logging event for localStorage
tyiuhc Sep 5, 2024
7efd994
handle case when receiver was not set during previous initialization
tyiuhc Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/analytics-connector/src/analyticsConnector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,21 @@ export class AnalyticsConnector {
safeGlobal['analyticsConnectorInstances'][instanceName] =
new AnalyticsConnector();
}
return safeGlobal['analyticsConnectorInstances'][instanceName];
const instance = safeGlobal['analyticsConnectorInstances'][instanceName];
// If the eventBridge is using old implementation, update with new instance
if (!instance.eventBridge.setInstanceName) {
const queue = instance.eventBridge.queue ?? [];
const receiver = instance.eventBridge.receiver;
instance.eventBridge = new EventBridgeImpl();
instance.eventBridge.setInstanceName(instanceName);
// handle case when receiver was not set during previous initialization
if (receiver) {
instance.eventBridge.setEventReceiver(receiver);
}
for (const event of queue) {
instance.eventBridge.logEvent(event);
}
}
return instance;
}
}