fix: implement consent-aware default user provider and remote flag storage #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Documentation updates detected! Updated existing suggestion: Document cookie consent handling for Experiment JavaScript SDK |
tyiuhc
changed the title
tyiuhc
requested review from
a team,
bgiori and
zhukaihan
and removed request for
bgiori
stephen-choi-amplitude
approved these changes
Oct 15, 2025
Collaborator
stephen-choi-amplitude
left a comment
stephen-choi-amplitude
left a comment
There was a problem hiding this comment.
Overall LGTM. A few minor nits
Co-authored-by: Stephen Choi <106711294+stephen-choi-amplitude@users.noreply.github.com>
…de/experiment-js-client into web/cookie-consent-user-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This update will pass consent-aware storage to be used by
ExperimentClientwhen storing default user properties and remote evaluation flagsChecklist